r111006 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111005‎ | r111006 | r111007 >
Date:01:16, 9 February 2012
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Revert r88270, r97711 and r110825 out of 1.19
Modified paths:
  • /branches/REL1_19/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /branches/REL1_19/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/REL1_19/phase3/includes/ChangesList.php (modified) (history)
  • /branches/REL1_19/phase3/includes/RecentChange.php (modified) (history)
  • /branches/REL1_19/phase3/includes/User.php (modified) (history)
  • /branches/REL1_19/phase3/includes/conf (deleted) (history)
  • /branches/REL1_19/phase3/maintenance/archives/patch-config.sql (deleted) (history)
  • /branches/REL1_19/phase3/maintenance/tables.sql (modified) (history)

Diff [purge]

Index: branches/REL1_19/phase3/RELEASE-NOTES-1.19
@@ -151,7 +151,6 @@
152152 * Allow moving the associated talk pages of subpages even if the base page
153153 has no subpage.
154154 * Per page edit-notices now work in namespaces without subpages enabled.
155 -* (bug 30245) Use the correct way to construct a log page title.
156155 * (bug 31081) $wgEnotifUseJobQ caused many unnecessary jobs to be queued.
157156 * (bug 30202) File names are now restricted on upload to 240 bytes, because of
158157 restrictions on some of the database fields.
Index: branches/REL1_19/phase3/includes/ChangesList.php
@@ -541,7 +541,7 @@
542542 if( $rc->mAttribs['rc_type'] == RC_MOVE || $rc->mAttribs['rc_type'] == RC_MOVE_OVER_REDIRECT ) {
543543 // Log entries
544544 } elseif( $rc->mAttribs['rc_log_type'] ) {
545 - $logtitle = SpecialPage::getTitleFor( 'Log', $rc->mAttribs['rc_log_type'] );
 545+ $logtitle = Title::newFromText( 'Log/'.$rc->mAttribs['rc_log_type'], NS_SPECIAL );
546546 $this->insertLog( $s, $logtitle, $rc->mAttribs['rc_log_type'] );
547547 // Log entries (old format) or log targets, and special pages
548548 } elseif( $rc->mAttribs['rc_namespace'] == NS_SPECIAL ) {
Index: branches/REL1_19/phase3/includes/AutoLoader.php
@@ -366,7 +366,6 @@
367367 'ApiUpload' => 'includes/api/ApiUpload.php',
368368 'ApiUserrights' => 'includes/api/ApiUserrights.php',
369369 'ApiWatch' => 'includes/api/ApiWatch.php',
370 - 'UsageException' => 'includes/api/ApiMain.php',
371370
372371 # includes/cache
373372 'CacheDependency' => 'includes/cache/CacheDependency.php',
@@ -388,10 +387,7 @@
389388 'TitleDependency' => 'includes/cache/CacheDependency.php',
390389 'TitleListDependency' => 'includes/cache/CacheDependency.php',
391390
392 - # includes/conf
393 - 'Conf' => 'includes/conf/Conf.php',
394 - 'DatabaseConf' => 'includes/conf/DatabaseConf.php',
395 - 'DefaultSettings' => 'includes/conf/DefaultSettings.php',
 391+ 'UsageException' => 'includes/api/ApiMain.php',
396392
397393 # includes/context
398394 'ContextSource' => 'includes/context/ContextSource.php',
Index: branches/REL1_19/phase3/includes/User.php
@@ -2753,14 +2753,6 @@
27542754
27552755 $this->load();
27562756 if ( 0 == $this->mId ) return;
2757 - if ( !$this->mToken ) {
2758 - // When token is empty or NULL generate a new one and then save it to the database
2759 - // This allows a wiki to re-secure itself after a leak of it's user table or $wgSecretKey
2760 - // Simply by setting every cell in the user_token column to NULL and letting them be
2761 - // regenerated as users log back into the wiki.
2762 - $this->setToken();
2763 - $this->saveSettings();
2764 - }
27652757 $session = array(
27662758 'wsUserID' => $this->mId,
27672759 'wsToken' => $this->mToken,
Index: branches/REL1_19/phase3/includes/RecentChange.php
@@ -672,7 +672,7 @@
673673 $wgCanonicalServer, $wgScript;
674674
675675 if( $this->mAttribs['rc_type'] == RC_LOG ) {
676 - $titleObj = SpecialPage::getTitleFor( 'Log', $this->mAttribs['rc_log_type'] );
 676+ $titleObj = Title::newFromText( 'Log/' . $this->mAttribs['rc_log_type'], NS_SPECIAL );
677677 } else {
678678 $titleObj =& $this->getTitle();
679679 }
Index: branches/REL1_19/phase3/maintenance/tables.sql
@@ -1473,14 +1473,4 @@
14741474 ) /*$wgDBTableOptions*/;
14751475 CREATE UNIQUE INDEX /*i*/md_module_skin ON /*_*/module_deps (md_module, md_skin);
14761476
1477 -CREATE TABLE /*_*/config (
1478 - -- Config var name
1479 - cf_name varbinary(255) NOT NULL PRIMARY KEY,
1480 - -- Config var value
1481 - cf_value blob NOT NULL
1482 -) /*$wgDBTableOptions*/;
1483 -CREATE INDEX /*i*/cf_name_value ON /*_*/config (cf_name,cf_value(255));
1484 -
14851477 -- vim: sw=2 sts=2 et
Index: branches/REL1_19/phase3/maintenance/archives/patch-config.sql
@@ -1,9 +0,0 @@
2 -CREATE TABLE /*_*/config (
3 - -- Config var name
4 - cf_name varbinary(255) NOT NULL PRIMARY KEY,
5 - -- Config var value
6 - cf_value blob NOT NULL
7 -) /*$wgDBTableOptions*/;
8 -CREATE INDEX /*i*/cf_name_value ON /*_*/config (cf_name,cf_value(255));

Follow-up revisions

RevisionCommit summaryAuthorDate
r111009SQLite doesn't want config either...reedy01:20, 9 February 2012
r111010Followup r111006...reedy01:21, 9 February 2012
r111123Die config table from 1.19reedy23:33, 9 February 2012
r111126Follow-up r111006: nuke patch-config for Oracle and DB2maxsem23:43, 9 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88270Initial commit of configuration management backend proposal. Feedback desired...demon21:04, 16 May 2011
r97711* (bug 30245) Use the correct way to construct a log page titlenikerabbit09:41, 21 September 2011
r110825(bug 34237) Regenerate an empty user_token and save to the database when we t...dantman08:07, 7 February 2012

Comments

#Comment by 😂 (talk | contribs)   01:39, 9 February 2012

Should've just reverted this out of trunk before branching. Meh.

Status & tagging log