r110964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110963‎ | r110964 | r110965 >
Date:20:58, 8 February 2012
Author:gregchiasson
Status:ok
Tags:aft, nodeploy 
Comment:
AFT5 feedback page. Put moderation tool filters into their own optgroup. Functionality is the same, but this pretties it up a bit per bug 34087
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/SpecialArticleFeedbackv5.php
@@ -239,8 +239,12 @@
240240 $counts = $this->getFilterCounts( $pageId );
241241 foreach ( $this->filters as $filter ) {
242242 $count = array_key_exists( $filter, $counts ) ? $counts[$filter] : 0;
243 - $key = $this->msg( 'articlefeedbackv5-special-filter-'.$filter, $count )->escaped();
244 - $opts[ (string) $key ] = $filter;
 243+ $key = $this->msg( 'articlefeedbackv5-special-filter-'.$filter, $count )->escaped();
 244+ if( in_array( $filter, array( 'comment', 'helpful', 'visible' ) ) ) {
 245+ $opts[ (string) $key ] = $filter;
 246+ } else {
 247+ $opts[ '---------' ][ (string) $key ] = $filter;
 248+ }
245249 }
246250
247251 $filterSelect = new XmlSelect( false, 'articleFeedbackv5-filter-select' );

Status & tagging log