r110963 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110962‎ | r110963 | r110964 >
Date:20:56, 8 February 2012
Author:catrope
Status:ok
Tags:miscextensions 
Comment:
Followup r110959: also remove the schema change in the hooks file
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
——@@ -208,15 +208,6 @@
209209 true
210210 ) );
211211
212 - // This change recreates the PK on a new field. Check for that new field's existence
213 - $updater->addExtensionUpdate( array(
214 - 'addField',
215 - 'article_feedback',
216 - 'aa_id',
217 - $dir . '/sql/RecreatePK.sql',
218 - true
219 - ) );
220 -
221212 return true;
222213 }
223214

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110959Revert most of r96722. The massive schema change was way overkill given that ...catrope20:21, 8 February 2012

Status & tagging log