r110928 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110927‎ | r110928 | r110929 >
Date:12:16, 8 February 2012
Author:hashar
Status:ok (Comments)
Tags:todo 
Comment:
align variables / enhance comment
Modified paths:
  • /trunk/phase3/includes/filerepo/FileRepo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/FileRepo.php
@@ -768,8 +768,10 @@
769769
770770 /**
771771 * Pick a random name in the temp zone and store a file to it.
772 - * Returns a FileRepoStatus object with the URL in the value.
 772+ * Returns a FileRepoStatus object with the file Virtual URL in the value,
 773+ * file can later be disposed using FileRepo::freeTemp().
773774 *
 775+ *
774776 * @param $originalName String: the base name of the file as specified
775777 * by the user. The file extension will be maintained.
776778 * @param $srcPath String: the current location of the file.
@@ -831,7 +833,7 @@
832834 /**
833835 * Remove a temporary file or mark it for garbage collection
834836 *
835 - * @param $virtualUrl String: the virtual URL returned by storeTemp
 837+ * @param $virtualUrl String: the virtual URL returned by FileRepo::storeTemp()
836838 * @return Boolean: true on success, false on failure
837839 */
838840 public function freeTemp( $virtualUrl ) {
@@ -840,8 +842,8 @@
841843 wfDebug( __METHOD__.": Invalid temp virtual URL\n" );
842844 return false;
843845 }
844 - $path = $this->resolveVirtualUrl( $virtualUrl );
845 - $op = array( 'op' => 'delete', 'src' => $path );
 846+ $path = $this->resolveVirtualUrl( $virtualUrl );
 847+ $op = array( 'op' => 'delete', 'src' => $path );
846848 $status = $this->backend->doOperation( $op );
847849 return $status->isOK();
848850 }

Comments

#Comment by 😂 (talk | contribs)   14:14, 8 February 2012

s/Virtual/virtual/ -- it's not a proper noun :)

Status & tagging log