r110725 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110724‎ | r110725 | r110726 >
Date:19:34, 5 February 2012
Author:amire80
Status:reverted (Comments)
Tags:aft 
Comment:
Makes the feedback textarea work correctly in an RTL environment.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.css
——@@ -618,6 +618,7 @@
619619 font-size: 1.1em;
620620 font-family: sans-serif !important;
621621 color: #999;
 622+ direction: ltr;
622623 }
623624
624625 .articleFeedbackv5-ui .feedback-text.active {

Sign-offs

UserFlagDate
Guobihuiinspected13:53, 11 February 2012 (struck 13:53, 11 February 2012)
Guobihuitested13:53, 11 February 2012 (struck 13:53, 11 February 2012)
Guobihuiinspected13:54, 11 February 2012
Guobihuitested13:54, 11 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r112341Reverting r110725 - doesn't seem to be relevant anymore.amire8018:57, 24 February 2012

Comments

#Comment by SPQRobin (talk | contribs)   12:30, 6 February 2012

All input/textareas are by default in the wiki content language direction. With this change it follows the user language, which I think is incorrect, because feedback will mostly be in the content language.

#Comment by Amire80 (talk | contribs)   18:58, 24 February 2012

I was sure that i replied to it, but apparently it wasn't posted.

Status & tagging log