r110640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110639‎ | r110640 | r110641 >
Date:02:18, 3 February 2012
Author:robin
Status:ok (Comments)
Tags:
Comment:
Add @noflip to arrow directions like "southwest", as that is the same location regardless of language directionality. The arrow was displayed at the wrong side. Also removing text-align:left; for the tooltip as the text direction should be set in html if needed, and shouldn't be overridden by (flipped) css.
Modified paths:
  • /trunk/phase3/resources/jquery.tipsy/jquery.tipsy.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.tipsy/jquery.tipsy.css
@@ -11,7 +11,6 @@
1212 border: solid 1px #a7d7f9;
1313 color: black;
1414 max-width: 15em;
15 - text-align: left;
1615 border-radius: 4px;
1716 -moz-border-radius: 4px;
1817 -webkit-border-radius: 4px;
@@ -30,36 +29,36 @@
3130 width: 11px;
3231 height: 6px;
3332 }
34 -.tipsy-n .tipsy-arrow {
 33+/* @noflip */ .tipsy-n .tipsy-arrow {
3534 top: 0px;
3635 left: 50%;
3736 margin-left: -5px;
3837 }
39 -.tipsy-nw .tipsy-arrow {
 38+/* @noflip */ .tipsy-nw .tipsy-arrow {
4039 top: 1px;
4140 left: 10px;
4241 }
43 -.tipsy-ne .tipsy-arrow {
 42+/* @noflip */ .tipsy-ne .tipsy-arrow {
4443 top: 1px;
4544 right: 10px;
4645 }
47 -.tipsy-s .tipsy-arrow {
 46+/* @noflip */ .tipsy-s .tipsy-arrow {
4847 bottom: 0px;
4948 left: 50%;
5049 margin-left: -5px;
5150 background-position: bottom left;
5251 }
53 -.tipsy-sw .tipsy-arrow {
 52+/* @noflip */ .tipsy-sw .tipsy-arrow {
5453 bottom: 0px;
5554 left: 10px;
5655 background-position: bottom left;
5756 }
58 -.tipsy-se .tipsy-arrow {
 57+/* @noflip */ .tipsy-se .tipsy-arrow {
5958 bottom: 0px;
6059 right: 10px;
6160 background-position: bottom left;
6261 }
63 -.tipsy-e .tipsy-arrow {
 62+/* @noflip */ .tipsy-e .tipsy-arrow {
6463 top: 50%;
6564 margin-top: -5px;
6665 right: 1px;
@@ -67,7 +66,7 @@
6867 height: 11px;
6968 background-position: top right;
7069 }
71 -.tipsy-w .tipsy-arrow {
 70+/* @noflip */ .tipsy-w .tipsy-arrow {
7271 top: 50%;
7372 margin-top: -5px;
7473 left: 0px;

Comments

#Comment by SPQRobin (talk | contribs)   02:25, 3 February 2012

Ow, fixes bug 34175.

#Comment by Siebrand (talk | contribs)   10:39, 3 February 2012

This is an external library. How are we ensuring that our local fixes are included upstream?

#Comment by Siebrand (talk | contribs)   10:43, 3 February 2012

By the way, it looks pretty unmaintained, as there are 28 open pull requests and 0 closed pull requests on https://github.com/jaz303/tipsy/pulls.

#Comment by SPQRobin (talk | contribs)   13:27, 3 February 2012

The original code is designed for LTR and doesn't take into account that it can be flipped, so @noflip is a MediaWiki-specific addition (although CSSJanus is also external). Plus, looking at the file history, we have made some local changes before.

#Comment by Kaldari (talk | contribs)   21:35, 3 February 2012

It looks like our local version is substantially different than the upstream version (in both JS and CSS). I've added a note to this effect in r110686.

Status & tagging log