r110582 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110581‎ | r110582 | r110583 >
Date:16:08, 2 February 2012
Author:amire80
Status:ok (Comments)
Tags:
Comment:
Fixes r110469 - message not localized.
Modified paths:
  • /trunk/extensions/Translate/api/ApiGroupReview.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/api/ApiGroupReview.php
@@ -48,7 +48,7 @@
4949 );
5050
5151 if ( $currentState == $requestParams['state'] ) {
52 - $this->dieUsage( wfMessage( 'translate-workflow-set-error-alreadyset' ), 'sameworkflowstate' );
 52+ $this->dieUsage( 'The requested state is identical to the current state', 'sameworkflowstate' );
5353 }
5454
5555 $dbw = wfGetDB( DB_MASTER );
@@ -137,6 +137,7 @@
138138 return array_merge( parent::getPossibleErrors(), array(
139139 array( 'code' => 'permissiondenied', 'info' => "You must have $right right" ),
140140 array( 'code' => 'disabled', 'info' => "Message group workflows are not in use" ),
 141+ array( 'code' => 'sameworkflowstate', 'info' => "The requested state is identical to the current state" ),
141142 ) );
142143 }
143144

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110469Fix bug 34046. If the same workflow state is already set, show an error messa...amire8010:04, 1 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   20:32, 3 February 2012

And is the message now unused?

#Comment by Reedy (talk | contribs)   20:32, 3 February 2012

It's still loaded into JS land....

Status & tagging log