r110516 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110515‎ | r110516 | r110517 >
Date:20:16, 1 February 2012
Author:reedy
Status:ok (Comments)
Tags:todo 
Comment:
Apparently null is better than 0 (or rather, doesn't break the world)
Modified paths:
  • /branches/wmf/1.18wmf1/maintenance/dumpInterwiki.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/maintenance/dumpInterwiki.php
——@@ -241,7 +241,7 @@
242242 $entry['iw_prefix'] = $this->prefixRewrites[$source][$entry['iw_prefix']];
243243 }
244244 if ( !array_key_exists( "iw_local", $entry ) ) {
245 - $entry["iw_local"] = 0;
 245+ $entry["iw_local"] = null;
246246 }
247247 if ( !array_key_exists( "iw_url", $entry ) ) {
248248 $entry["iw_url"] = '';

Comments

#Comment by Aaron Schulz (talk | contribs)   20:17, 1 February 2012

This code needs documentation.

#Comment by RobLa-WMF (talk | contribs)   20:33, 1 February 2012

Perhaps a comment needed? Added "todo" tag

#Comment by Krinkle (talk | contribs)   20:18, 1 February 2012

uh ?

#Comment by Reedy (talk | contribs)   20:37, 1 February 2012

Set to 0 and interwiki links on the cluster are broken

Set it to null and they're not

Status & tagging log