r110484 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110483‎ | r110484 | r110485 >
Date:15:36, 1 February 2012
Author:amire80
Status:reverted (Comments)
Tags:core 
Comment:
Integer comparison in Hebrew plural forms.
Modified paths:
  • /trunk/phase3/languages/classes/LanguageHe.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/classes/LanguageHe.php
@@ -59,9 +59,9 @@
6060 if ( !count( $forms ) ) { return ''; }
6161 $forms = $this->preConvertPlural( $forms, 3 );
6262
63 - if ( $count == '1' ) {
 63+ if ( $count === '1' ) {
6464 return $forms[0]; // Singular
65 - } elseif ( $count == '2' ) {
 65+ } elseif ( $count === '2' ) {
6666 return $forms[2]; // Dual or plural if dual is not provided (filled in preConvertPlural)
6767 } else {
6868 return $forms[1]; // Plural

Follow-up revisions

RevisionCommit summaryAuthorDate
r110492Fixes r110484.amire8015:53, 1 February 2012

Comments

#Comment by 😂 (talk | contribs)   15:50, 1 February 2012
#Comment by Catrope (talk | contribs)   20:22, 2 February 2012

Essentially reverted in r110572.

Status & tagging log