r110454 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110453‎ | r110454 | r110455 >
Date:01:09, 1 February 2012
Author:reedy
Status:ok (Comments)
Tags:miscextensions 
Comment:
Revert part of r109617

Breaks updates. Will re-evaluate it after sleep

Remove big seperator
Modified paths:
  • /trunk/extensions/WikimediaMaintenance/dumpInterwiki.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikimediaMaintenance/dumpInterwiki.php
@@ -235,8 +235,6 @@
236236 }
237237 }
238238
239 - # ------------------------------------------------------------------------------------------
240 -
241239 /**
242240 * Executes part of an INSERT statement, corresponding to all interlanguage links to a particular site
243241 *
@@ -271,12 +269,6 @@
272270 array_key_exists( $entry['iw_prefix'], $this->prefixRewrites[$source] ) ) {
273271 $entry['iw_prefix'] = $this->prefixRewrites[$source][$entry['iw_prefix']];
274272 }
275 - if ( !array_key_exists( "iw_local", $entry ) ) {
276 - $entry["iw_local"] = 0;
277 - }
278 - if ( !array_key_exists( "iw_url", $entry ) ) {
279 - return;
280 - }
281273 if ( $this->dbFile ) {
282274 $this->dbFile->set( "{$source}:{$entry['iw_prefix']}", trim( "{$entry['iw_local']} {$entry['iw_url']}" ) );
283275 } else {

Follow-up revisions

RevisionCommit summaryAuthorDate
r110455Revert out part of r109618, after r110454reedy01:11, 1 February 2012
r110487Followup r110454, quieten script by setting default values for non set iw_url...reedy15:46, 1 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109617Cleanup WikimediaMaintenance scripts slightly...reedy14:36, 20 January 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   01:12, 1 February 2012

Always got to slip in some style cleanup :)

Status & tagging log