r110429 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110428‎ | r110429 | r110430 >
Date:21:00, 31 January 2012
Author:pgehres
Status:ok (Comments)
Tags:
Comment:
Adding new message to ignores list for DonationInterface FU r110428
Modified paths:
  • /trunk/translatewiki/MediaWiki/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/translatewiki/MediaWiki/mediawiki-defines.txt
——@@ -431,7 +431,7 @@
432432 ignored = donate_interface-big-amount-display, donate_interface-medium-amount-display
433433 ignored = donate_interface-small-amount-display, donate_interface-big-amount-value
434434 ignored = donate_interface-medium-amount-value, donate_interface-small-amount-value
435 -ignored = donate_interface-donor-fname-alt, donate_interface-donor-lname-alt
 435+ignored = donate_interface-donor-fname-alt, donate_interface-donor-lname-alt, donate_interface-donor-postcode
436436
437437 Donation Interface - Global Collect Gateway
438438 id = ext-di-gcg

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110428Adding alternate postal code messagepgehres21:00, 31 January 2012

Comments

#Comment by Siebrand (talk | contribs)   23:25, 31 January 2012

Why should this not be translated?

#Comment by Pgehres (WMF) (talk | contribs)   23:51, 31 January 2012

Well, I am not sure how it differs from donate_interface-donor-postal except in the en version. I suppose it should probably be set to Template:Identical. Would it then be possible to make all of the non-en messages for donate_interface-donor-postcode match donate_interface-donor-postal?

#Comment by Siebrand (talk | contribs)   08:40, 1 February 2012

Maybe I just don't understand what the "alternate postal code message" is for. Can you elaborate?

#Comment by Pgehres (WMF) (talk | contribs)   19:18, 1 February 2012

Sure. Apparently there are countries that use the english term "Postcode" for a postal code instead of "Postal code" Thus, we needed another message to store "Postcode"

Status & tagging log