r110385 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110384‎ | r110385 | r110386 >
Date:13:42, 31 January 2012
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Address CR comments:
* Follow-up r110373: Update copyright years and author information.
* Follow-up r110375: Update change log and other parts of README.
* Follow-up r110379: Provide some output when invalid group names have been provided.
Modified paths:
  • /trunk/extensions/Translate/README (modified) (history)
  • /trunk/extensions/Translate/scripts/export.php (modified) (history)
  • /trunk/extensions/Translate/scripts/sync-group.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/scripts/sync-group.php
@@ -3,7 +3,9 @@
44 * Command line script to import/update source messages and translations into the wiki database.
55 *
66 * @author Niklas Laxström
7 - * @copyright Copyright © 2007-2010, Niklas Laxström
 7+ * @author Siebrand Mazeland
 8+ * @copyright Copyright © 2007-2012, Niklas Laxström
 9+ * @copyright Copyright © 2009-2012, Siebrand Mazeland
810 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
911 * @file
1012 */
@@ -56,6 +58,8 @@
5759
5860 if( $group !== null ) {
5961 $groups[$groupId] = $group;
 62+ } else {
 63+ STDERR( "Invalid group $groupId" );
6064 }
6165 }
6266 } else {
Index: trunk/extensions/Translate/scripts/export.php
@@ -4,7 +4,7 @@
55 *
66 * @author Niklas Laxstrom
77 * @author Siebrand Mazeland
8 - * @copyright Copyright © 2008-2010, Niklas Laxström, Siebrand Mazeland
 8+ * @copyright Copyright © 2008-2012, Niklas Laxström, Siebrand Mazeland
99 * @license http://www.gnu.org/copyleft/gpl.html GNU General Public License 2.0 or later
1010 * @file
1111 */
@@ -101,6 +101,8 @@
102102
103103 if( $group !== null ) {
104104 $groups[$groupId] = $group;
 105+ } else {
 106+ STDERR( "Invalid group $groupId" );
105107 }
106108 }
107109 } else {
Index: trunk/extensions/Translate/README
@@ -15,30 +15,68 @@
1616 http://translatewiki.net/wiki/Translating:Documentation#Documentation_for_system_administrators
1717
1818 == Contributing ==
19 -Translations? -> go to http://translatewiki.net and sign up.
20 -Code? File format handlers? New message groups? Graphics? Suggestions?
21 -Bug reports? -> please start a thread at http://translatewiki.net/wiki/Support
22 -or join us at #mediawiki-i18n and let us know what you have in mind.
 19+* Translations? Go to https://translatewiki.net and sign up.
 20+* Code? File format handlers? New message groups? Graphics? Suggestions?
 21+* Bug reports? Please start a thread at http://translatewiki.net/wiki/Support,
 22+ report a bug in https://bugzilla.wikimedia.org or join us at #mediawiki-i18n
 23+ and let us know what you have in mind.
2324
24 -Bugs and feature requests are collected at:
25 - http://translatewiki.net/wiki/Issues_and_features
 25+Some known bugs and feature requests are collected at:
 26+ https://translatewiki.net/wiki/Issues_and_features
2627
2728 Documentation for the extension is at:
28 - http://translatewiki.net/wiki/Translating:Documentation
 29+ https://www.mediawiki.org/wiki/Help:Extension:Translate
2930 And for the code at:
30 - http://translatewiki.net/docs/Translate/html/
 31+ https://translatewiki.net/docs/Translate/html/
3132
3233 == Change log ==
3334 * 2012-01-31
34 -- export.php: switch "grouptrail" renamed to "groupprefix" and switch "groups"
 35+- export.php: switch "grouptrail" renamed to "groupprefix" and switch "groups".
3536 was dropped. "group" now takes a comma separated list of groups IDs, too.
3637 - sync-group.php: switch "groupprefix" added.
 38+- Double counting of messages when adding message groups and aggregate groups to
 39+ another aggregate group was partially resolved.
 40+- Messages for translatable pages for which translation is discouraged, are no
 41+ longer added to aggregate message groups to avoid mismatches in statistics.
 42+- Special:MessageGroupStats now works for group IDs with spaces.
 43+- Updates were made for the translation memory service, to avoid serving
 44+ incorrect or outdated suggestions.
 45+* 2012-01-30
 46+- Statictics issues introduced recently were resolved.
 47+- "lang" attributes were added to Special:SupportedLanguages.
 48+- [[Special:Translate/groupname]] links for translatable pages with spaces or
 49+ colons in them are now possible. For page "Some page" it is:
 50+ [[Special:Translate/page-Some_page]].
 51+- The JavaScript translation editor now shows the code browser and gettext
 52+ comments when translating aggregate message groups.
 53+- Logging was added group statistics caching to determine if cache purges happen
 54+ too often.
 55+* 2012-01-29
 56+- Update functionality for the translation memory was added.
 57+* 2012-01-28
 58+- Code readability improvements were made.
 59+- A translation memory service was added, including a bootstrap script.
 60+* 2012-01-22
 61+- Message groups are no longer forced to implement getBools. getTags is the
 62+ official way to do this.
 63+- getDefinitions was added to the MessageGroupInterface.
 64+- The public $namespaces variable in MessageGroup was removed.
 65+* 2012-01-20
 66+- Browser compatibility updates were made in CSS.
 67+* 2012-01-19
 68+- Deprecated hook LanguageGetMagic was removed.
 69+* 2012-01-16
 70+- Help icons linking to documentation at
 71+ https://www.mediawiki.org/Help:Extension:Translate or sub pages were added to
 72+ extension functionality.
 73+- Backward compatibility with MediaWiki 1.18 was restored.
3774 * 2012-01-13
38 -- export.php has a switch "--no-fuzzy" that will filter out fuzzy messages
39 - for file based message groups.
 75+- export.php has a switch "no-fuzzy" that will filter out fuzzy messages for
 76+ file based message groups.
4077 - Special:PageTranslation has now better error checking for invalid and
4178 duplicate translation unit names.
4279 - Special pages have now help links.
 80+- Images were moved to a resources sub folder.
4381 * 2012-01-11
4482 - Translate page group id prefix was changed from page| to page-. Some old
4583 links need to be updated, some still work.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110373Change "grouptrail" switch to "groupprefix" and update documentation.siebrand10:09, 31 January 2012
r110375* switch "groups" in export.php dropped. "group" now takes a comma separated ...siebrand10:25, 31 January 2012
r110379Add missing switch documentation and add a check for valid message groups.siebrand10:43, 31 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   14:00, 31 January 2012

Hey thanks a lot! I know it's annoying and time confusing to update the change log.

Status & tagging log