r110356 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110355‎ | r110356 | r110357 >
Date:02:49, 31 January 2012
Author:liangent
Status:ok (Comments)
Tags:
Comment:
(bug 33959) Special:CongressLookup fails when not accessed via pretty URL
Modified paths:
  • /trunk/extensions/CongressLookup/SpecialCongressLookup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CongressLookup/SpecialCongressLookup.php
@@ -212,8 +212,12 @@
213213 if ( $isError ) {
214214 $htmlOut .= Html::element( 'p', array( 'class' => 'error' ), wfMsg( 'congresslookup-zipcode-error' ));
215215 }
 216+ $htmlOut .= Html::openElement( 'form', array(
 217+ 'action' => wfScript(),
 218+ 'method' => 'get',
 219+ ) );
 220+ $htmlOut .= Html::hidden( 'title', $this->getTitle()->getPrefixedText() );
216221 $htmlOut .= <<<HTML
217 - <form action="" method="GET">
218222 <label for="zip">Your zip code:</label>
219223 <input type="text" maxlength="10" size="5" name="zip" id="zip"/>
220224 <input type="submit" value="Look up" name="submit"/>

Comments

#Comment by MaxSem (talk | contribs)   08:27, 31 January 2012

You've removed the opening tag, but left the closing one.

#Comment by Nikerabbit (talk | contribs)   08:38, 31 January 2012

What tag?

#Comment by MaxSem (talk | contribs)   08:55, 31 January 2012

Brr, my bad:)

Status & tagging log