r110299 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110298‎ | r110299 | r110300 >
Date:16:22, 30 January 2012
Author:rsterbin
Status:ok
Tags:aft 
Comment:
Changed overlay impression event to fire every time the modal window is opened, not just the first time
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2169,6 +2169,7 @@
21702170 $.articleFeedbackv5.$holder.appear( function () {
21712171 if ( !$.articleFeedbackv5.isLoaded ) {
21722172 $.articleFeedbackv5.load( 'auto', 'bottom' );
 2173+ $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-bottom' );
21732174 }
21742175 } );
21752176 // Keep track of links that must be removed after a successful submission
@@ -2633,9 +2634,6 @@
26342635 bucket.afterBuild();
26352636 }
26362637
2637 - // Track the event
2638 - $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-' + from );
2639 -
26402638 $.articleFeedbackv5.nowShowing = 'form';
26412639 };
26422640
@@ -3076,6 +3074,9 @@
30773075 $.articleFeedbackv5.$dialog.dialog( 'open' );
30783076 $.articleFeedbackv5.setLinkId( $link.data( 'linkId' ) );
30793077
 3078+ // Track the impression
 3079+ $.articleFeedbackv5.trackClick( $.articleFeedbackv5.bucketName() + '-impression-overlay' );
 3080+
30803081 // Hide the panel
30813082 $.articleFeedbackv5.$holder.hide();
30823083

Status & tagging log