r110298 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110297‎ | r110298 | r110299 >
Date:15:54, 30 January 2012
Author:hashar
Status:ok
Tags:
Comment:
make sure we test normalization against normalized title

This patch fix ApiQueryTest::testTitlesGetNormalized() when $wgMetaNamespace
would contains space / underscore.

Example:
-8<-------------8<------------8<------------------8<----------8<------
1) ApiQueryTest::testTitlesGetNormalized
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
'from' => 'Project:articleA'
- 'to' => 'My_Project:ArticleA'
+ 'to' => 'My Project:ArticleA'
)
-8<-------------8<------------8<------------------8<----------8<------

This patch use Title class logic to forge a normalized title instead of
manually creating it by appending two strings.

Final fix to bug 33663 (comment 21):
https://bugzilla.wikimedia.org/show_bug.cgi?id=33663#c21
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/api/ApiQueryTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/api/ApiQueryTest.php
@@ -22,10 +22,13 @@
2323 $this->assertArrayHasKey( 'query', $data[0] );
2424 $this->assertArrayHasKey( 'normalized', $data[0]['query'] );
2525
 26+ // Forge a normalized title
 27+ $to = Title::newFromText( $wgMetaNamespace.':ArticleA' );
 28+
2629 $this->assertEquals(
2730 array(
2831 'from' => 'Project:articleA',
29 - 'to' => $wgMetaNamespace . ':ArticleA'
 32+ 'to' => $to->getPrefixedText(),
3033 ),
3134 $data[0]['query']['normalized'][0]
3235 );

Status & tagging log