r110252 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r110251‎ | r110252 | r110253 >
Date:19:05, 29 January 2012
Author:krinkle
Status:resolved
Tags:
Comment:
[specials] Xml::namespaceSelector > Html::namespaceSelector
* Makes front-end more reliable by not relying on Xml::namespaceSelector to use name="namespace" in it's output, which these forms where then requesting hardcoded from WebRequest
* Poke r109990
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllpages.php
@@ -127,7 +127,10 @@
128128 Xml::label( $this->msg( 'namespace' )->text(), 'namespace' ) .
129129 " </td>
130130 <td class='mw-input'>" .
131 - Xml::namespaceSelector( $namespace, null ) . ' ' .
 131+ Html::namespaceSelector(
 132+ array( 'selected' => $namespace ),
 133+ array( 'name' => 'namespace', 'id' => 'namespace' )
 134+ ) . ' ' .
132135 Xml::submitButton( $this->msg( 'allpagessubmit' )->text() ) .
133136 " </td>
134137 </tr>";
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -655,7 +655,10 @@
656656 * @return String
657657 */
658658 protected function namespaceFilterForm( FormOptions $opts ) {
659 - $nsSelect = Xml::namespaceSelector( $opts['namespace'], '' );
 659+ $nsSelect = Html::namespaceSelector(
 660+ array( 'selected' => $opts['namespace'], 'all' => '' ),
 661+ array( 'name' => 'namespace', 'id' => 'namespace' )
 662+ );
660663 $nsLabel = Xml::label( wfMsg( 'namespace' ), 'namespace' );
661664 $invert = Xml::checkLabel(
662665 wfMsg( 'invert' ), 'invert', 'nsinvert',

Follow-up revisions

RevisionCommit summaryAuthorDate
r110276drop default parameters from r110252...hashar11:08, 30 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109990[Xml/Html] new method Html::namespaceSelector...krinkle03:01, 25 January 2012

Status & tagging log