r109964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109963‎ | r109964 | r109965 >
Date:22:37, 24 January 2012
Author:gregchiasson
Status:ok (Comments)
Tags:aft 
Comment:
AFT5 - Add some qqq translation explanation, as a followup to r109075
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/ArticleFeedbackv5.i18n.php
@@ -55,8 +55,6 @@
5656 'articlefeedbackv5-form-helpful-votes' => '({{PLURAL:$1|1 response|$1 responses}}: {{PLURAL:$2|1 yes|$2 yes}} / {{PLURAL:$3|1 no|$3 no}})',
5757 'articlefeedbackv5-special-add-feedback' => 'Add your feedback',
5858 'articlefeedbackv5-special-filter-all' => 'All ($1)',
59 - 'articlefeedbackv5-special-filter-almostall' => 'All ($1)',
60 - 'articlefeedbackv5-special-filter-notall' => 'All ($1)',
6159 'articlefeedbackv5-special-filter-comment' => 'Comments only ($1)',
6260 'articlefeedbackv5-special-filter-abusive' => 'Abusive ($1)',
6361 'articlefeedbackv5-special-filter-helpful' => 'Helpful ($1)',
@@ -352,6 +350,10 @@
353351 'articlefeedbackv5-form-helpful-yes-label' => '{{Identical|Yes}}',
354352 'articlefeedbackv5-form-helpful-no-label' => '{{Identical|No}}',
355353 'articlefeedbackv5-special-filter-all' => '{{Identical|All}}',
 354+ 'articlefeedbackv5-special-filter-comment' => 'Feedback with text comments',
 355+ 'articlefeedbackv5-special-filter-abusive' => '{{Identical|Abusive}}',
 356+ 'articlefeedbackv5-special-filter-helpful' => 'Feedback that has been marked as helpful',
 357+ 'articlefeedbackv5-special-filter-unhelpful' => 'Feedback that has been marked as unhelpful',
356358 'articlefeedbackv5-special-filter-invisible' => '{{Identical|Hidden}}',
357359 'articlefeedbackv5-special-filter-deleted' => '{{Identical|Deleted}}',
358360 'articlefeedbackv5-special-sort-age' => '{{Identical|Date}}',
@@ -360,6 +362,10 @@
361363 'articlefeedbackv5-special-pagetitle' => 'Page title for [[Special:ArticleFeedbackv5]]. Parameters:
362364 * $1 is the title of the article for which we show the feedback',
363365 'articlefeedbackv5-form-delete' => '{{Identical|Delete}}',
 366+ 'articlefeedbackv5-form-oversight' => 'Request that an oversighter review this feedback',
 367+ 'articlefeedbackv5-form-unoversight' => 'Remove request for oversight',
 368+ 'articlefeedbackv5-oversight-saved' => 'Oversight request saved successfully',
 369+ 'articlefeedbackv5-unoversight-saved' => 'Request for oversight removed successfully',
364370 'articlefeedbackv5-form-header' => "* '''$1''' is the feedback ID.
365371 * '''$2''' is the date and time at which the feedback was given.",
366372 'articlefeedbackv5-form1-header-found' => 'Parameters:

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109075AFT5 - Add ability to 'delete' (super-hide, visible to oversight only) commen...gregchiasson23:12, 16 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   22:45, 24 January 2012
-	'articlefeedbackv5-special-filter-almostall' => 'All ($1)',
-	'articlefeedbackv5-special-filter-notall' => 'All ($1)',

This wasn't in your commit message.

#Comment by Gregchiasson (talk | contribs)   22:51, 24 January 2012

Fair enough - I also removed a couple of unused messages while I was in there. Is there an accepted practice for amending the commit (revert and recommit?), or is posting a comment here sufficient?

#Comment by Johnduhart (talk | contribs)   22:53, 24 January 2012

The comment here is fine, just be sure to note everything changed in your commit message from now on.

Status & tagging log