r109943 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109942‎ | r109943 | r109944 >
Date:19:58, 24 January 2012
Author:rsterbin
Status:ok
Tags:
Comment:
Swapped the dimensions of the survey window and made it close the CTA as soon as you start the survey
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js
@@ -2106,9 +2106,14 @@
21072107 directories=0,\
21082108 resizable=1,\
21092109 scrollbars=1,\
2110 - height=600,\
2111 - width=800';
 2110+ height=800,\
 2111+ width=600';
21122112 var survey = window.open( link, 'survey', params );
 2113+ if ( $.articleFeedbackv5.inDialog ) {
 2114+ $.articleFeedbackv5.closeAsModal();
 2115+ } else {
 2116+ $.articleFeedbackv5.clear();
 2117+ }
21132118 } );
21142119
21152120 },

Follow-up revisions

RevisionCommit summaryAuthorDate
r1100191.18wmf1: MFT r109875, r109933, r109943catrope19:34, 25 January 2012

Status & tagging log