r109906 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109905‎ | r109906 | r109907 >
Date:07:04, 24 January 2012
Author:mkroetzsch
Status:ok (Comments)
Tags:
Comment:
fixed feature request Bug 9892 as suggested by LY Meng
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Subobject.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/parserhooks/SMW_Subobject.php
@@ -41,8 +41,9 @@
4242 foreach ( $params as $param ) {
4343 $parts = explode( '=', trim( $param ), 2 );
4444
45 - // Only add the property when there is both a name and a value.
46 - if ( count( $parts ) == 2 ) {
 45+ // Only add the property when there is both a name
 46+ // and a non-empty value.
 47+ if ( count( $parts ) == 2 && $parts[1] != '' ) {
4748 self::addPropertyValueToSemanticData( $parts[0], $parts[1], $semanticData );
4849 } else {
4950 //self::$m_errors[] = wfMsgForContent( 'smw_noinvannot' );

Comments

#Comment by Jeroen De Dauw (talk | contribs)   19:01, 24 January 2012

It's bug 33901 :)

Status & tagging log