r109838 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109837‎ | r109838 | r109839 >
Date:18:22, 23 January 2012
Author:seanheavey
Status:resolved (Comments)
Tags:
Comment:
further css development for 1:30 push to prototype
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_negative.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_positive.png (modified) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_negative.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_positive.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
@@ -20,7 +20,7 @@
2121 }
2222 #articleFeedbackv5-showing-count-wrap {
2323 float: left;
24 - margin: 0 0 5px;
 24+ margin: 0 0 15px;
2525 }
2626 #articleFeedbackv5-percent-found-wrap {
2727 clear: left;
@@ -68,7 +68,8 @@
6969 }
7070 #articleFeedbackv5-filter-select {
7171 position: relative;
72 - top: 10px;
 72+ top: 9x;
 73+ left: 3px;
7374 float: none;
7475 display: inline-block;
7576 }
@@ -79,8 +80,8 @@
8081 .articleFeedbackv5-feedback {
8182 min-width: 650px;
8283 position: relative;
83 - padding: 10px 10px 09px;
84 - border-bottom: 1px solid #d6d6d6;
 84+ padding: 10px 10px 8px;
 85+ border-bottom: 2px solid #d6d6d6;
8586 overflow: hidden;
8687 }
8788 .articleFeedbackv5-feedback:after {
@@ -139,9 +140,9 @@
140141 cursor: pointer;
141142 }
142143 .articleFeedbackv5-feedback:hover {
143 - padding: 9px 10px;
144 - border-top: 1px solid #3366bb;
145 - border-bottom: 1px solid #3366bb;
 144+ padding: 8px 10px;
 145+ border-top: 2px solid #3366bb;
 146+ border-bottom: 2px solid #3366bb;
146147 }
147148 .articleFeedbackv5-feedback:hover .articleFeedbackv5-feedback-tools {
148149 display: block;
@@ -165,18 +166,19 @@
166167 float: right;
167168 }
168169 #articleFeedbackv5-special-add-feedback {
169 - color:white;
 170+ /*color:white;
170171 display: block;
171 - -webkit-border-radius: 5px;
172 - -moz-border-radius: 5px;
173 - -ms-border-radius: 5px;
174 - border-radius: 5px;
 172+ -webkit-border-radius: 3px;
 173+ -moz-border-radius: 3px;
 174+ -ms-border-radius: 3px;
 175+ border-radius: 3px;
175176 width: auto;
176177 height: 35px;
177178 line-height: 35px;
178179 padding: 0 9px;
179180 float: right;
180 - background: url(images/bg-submit.png) repeat-x;
 181+ background: url(images/bg-submit.png) repeat-x;*/
 182+ display: none;
181183 }
182184 #articleFeedbackv5-special-add-feedback:after {
183185 clear:both;
@@ -203,11 +205,12 @@
204206 background: url(images/bg-button-disable.png) repeat-x;
205207 -moz-border-radius: 3px;
206208 -webkit-border-radius: 3px;
207 - border-radius: 3px; /* future proofing */
208 - -khtml-border-radius: 3px; /* for old Konqueror browsers */
209 - -moz-box-shadow: -2px 2px 1px #999;
 209+ border-radius: 3px;
 210+ -khtml-border-radius: 3px;
 211+ /*-moz-box-shadow: -2px 2px 1px #999;
210212 -webkit-box-shadow: -2px 2px 1px #999;
211 - box-shadow: -2px 2px 1px #999;
 213+ box-shadow: -2px 2px 1px #999;*/
 214+ border: 1px solid #999;
212215 }
213216
214217 #articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-helpful-link:hover,

Comments

#Comment by Johnduhart (talk | contribs)   18:25, 23 January 2012

Still no @embeds

#Comment by Rsterbin (talk | contribs)   00:36, 31 January 2012

These are fixed now, but I don't think Sean has the right permissions to set this back to new. Doing that now.

Status & tagging log