r109826 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109825‎ | r109826 | r109827 >
Date:15:04, 23 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Bug 33880 - $wgUsersNotifiedOnAllChanges should not send e-mail to user who made the edit.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -231,6 +231,8 @@
232232 * (bug 33819) Display file sizes in appropriate units.
233233 * (bug 32948) {{REVISIONID}} and related variables are no longer blank after doing
234234 a null edit.
 235+* (bug 33880) $wgUsersNotifiedOnAllChanges should not send e-mail to user who made
 236+ the edit.
235237
236238 === API changes in 1.19 ===
237239 * Made action=edit less likely to return "unknownerror", by returning the actual error
Index: trunk/phase3/includes/UserMailer.php
@@ -512,6 +512,10 @@
513513
514514 global $wgUsersNotifiedOnAllChanges;
515515 foreach ( $wgUsersNotifiedOnAllChanges as $name ) {
 516+ if ( $editor->getName() == $name ) {
 517+ // No point notifying the user that actually made the change!
 518+ continue;
 519+ }
516520 $user = User::newFromName( $name );
517521 $this->compose( $user );
518522 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r109827update wgUsersNotifiedOnAllChanges doc (r109826)hashar16:08, 23 January 2012

Status & tagging log