r109805 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109804‎ | r109805 | r109806 >
Date:03:22, 23 January 2012
Author:varnent
Status:resolved (Comments)
Tags:
Comment:
Outputs escaped per r109341
Modified paths:
  • /trunk/extensions/Blackout/skins/ProtestSopa.php (modified) (history)
  • /trunk/extensions/Blackout/skins/SopaStrike.php (modified) (history)
  • /trunk/extensions/Blackout/skins/StopSopa.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Blackout/skins/ProtestSopa.php
@@ -12,13 +12,13 @@
1313 * to show the actual HTML output
1414 */
1515 public function execute() {
16 - $header = wfMsg( 'blackout-protestsopa-header' );
17 - $message1 = wfMsg( 'blackout-protestsopa-message1' );
18 - $message2 = wfMsg( 'blackout-protestsopa-message2' );
19 - $message3 = wfMsg( 'blackout-protestsopa-message3' );
20 - $action = wfMsg( 'blackout-protestsopa-action' );
21 - $actionmsg = wfMsg( 'blackout-protestsopa-actionmsg' );
22 - $join = wfMsg( 'blackout-protestsopa-join' );
 16+ $header = wfMsg( 'blackout-protestsopa-header', escape );
 17+ $message1 = wfMsg( 'blackout-protestsopa-message1', escape );
 18+ $message2 = wfMsg( 'blackout-protestsopa-message2', escape );
 19+ $message3 = wfMsg( 'blackout-protestsopa-message3', escape );
 20+ $action = wfMsg( 'blackout-protestsopa-action', escape );
 21+ $actionmsg = wfMsg( 'blackout-protestsopa-actionmsg', escape );
 22+ $join = wfMsg( 'blackout-protestsopa-join', escape );
2323 ?>
2424
2525 <html>
Index: trunk/extensions/Blackout/skins/SopaStrike.php
@@ -12,28 +12,28 @@
1313 * to show the actual HTML output
1414 */
1515 public function execute() {
16 - $title = wfMsg( 'blackout-sopastrike-title' );
17 - $ogdesc = wfMsg( 'blackout-sopastrike-ogdesc' );
18 - $message1 = wfMsg( 'blackout-sopastrike-message1' );
19 - $message2 = wfMsg( 'blackout-sopastrike-message2' );
20 - $message3 = wfMsg( 'blackout-sopastrike-message3' );
21 - $name = wfMsg( 'allmessagesname' );
22 - $email = wfMsg( 'email' );
23 - $address = wfMsg( 'blackout-sopastrike-address' );
24 - $zipcode = wfMsg( 'blackout-sopastrike-zipcode' );
25 - $action = wfMsg( 'blackout-sopastrike-action' );
26 - $actionmsg1 = wfMsg( 'blackout-sopastrike-actionmsg1' );
27 - $actionmsg2 = wfMsg( 'blackout-sopastrike-actionmsg2' );
28 - $join = wfMsg( 'blackout-sopastrike-join' );
29 - $add = wfMsg( 'blackout-sopastrike-add' );
30 - $learn = wfMsg( 'blackout-sopastrike-learn' );
31 - $video = wfMsg( 'blackout-sopastrike-video' );
 16+ $title = wfMsg( 'blackout-sopastrike-title', escape );
 17+ $ogdesc = wfMsg( 'blackout-sopastrike-ogdesc', escape );
 18+ $message1 = wfMsg( 'blackout-sopastrike-message1', escape );
 19+ $message2 = wfMsg( 'blackout-sopastrike-message2', escape );
 20+ $message3 = wfMsg( 'blackout-sopastrike-message3', escape );
 21+ $name = wfMsg( 'allmessagesname', escape );
 22+ $email = wfMsg( 'email', escape );
 23+ $address = wfMsg( 'blackout-sopastrike-address', escape );
 24+ $zipcode = wfMsg( 'blackout-sopastrike-zipcode', escape );
 25+ $action = wfMsg( 'blackout-sopastrike-action', escape );
 26+ $actionmsg1 = wfMsg( 'blackout-sopastrike-actionmsg1', escape );
 27+ $actionmsg2 = wfMsg( 'blackout-sopastrike-actionmsg2', escape );
 28+ $join = wfMsg( 'blackout-sopastrike-join', escape );
 29+ $add = wfMsg( 'blackout-sopastrike-add', escape );
 30+ $learn = wfMsg( 'blackout-sopastrike-learn', escape );
 31+ $video = wfMsg( 'blackout-sopastrike-video', escape );
3232 $orgpage = wfMsg( 'blackout-sopastrike-orgpage' );
33 - $infographic = wfMsg( 'blackout-sopastrike-infographic' );
34 - $ocsopa = wfMsg( 'blackout-sopastrike-ocsopa' );
35 - $ocpipa = wfMsg( 'blackout-sopastrike-ocpipa' );
36 - $disclaimer = wfMsg( 'blackout-sopastrike-disclaimer' );
37 - $privacy = wfMsg( 'blackout-sopastrike-privacy' );
 33+ $infographic = wfMsg( 'blackout-sopastrike-infographic', escape );
 34+ $ocsopa = wfMsg( 'blackout-sopastrike-ocsopa', escape );
 35+ $ocpipa = wfMsg( 'blackout-sopastrike-ocpipa', escape );
 36+ $disclaimer = wfMsg( 'blackout-sopastrike-disclaimer', escape );
 37+ $privacy = wfMsg( 'blackout-sopastrike-privacy', escape );
3838 ?>
3939
4040 <!DOCTYPE html>
Index: trunk/extensions/Blackout/skins/StopSopa.php
@@ -12,8 +12,8 @@
1313 * to show the actual HTML output
1414 */
1515 public function execute() {
16 - $header = wfMsgExt( 'blackout-stopsopa-header' );
17 - $message = wfMsgExt( 'blackout-stopsopa-message' );
 16+ $header = wfMsgExt( 'blackout-stopsopa-header', escape );
 17+ $message = wfMsgExt( 'blackout-stopsopa-message', escape );
1818 ?>
1919
2020 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"

Follow-up revisions

RevisionCommit summaryAuthorDate
r109858Fix for r109805, r109341: properly escape messagesdemon22:24, 23 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109341localisationvarnent08:11, 18 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   10:42, 23 January 2012

wfMsg doesn't take 'escape'.

Status & tagging log