r109762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109761‎ | r109762 | r109763 >
Date:21:45, 22 January 2012
Author:jpostlethwaite
Status:ok (Comments)
Tags:
Comment:
Adding UnitTest Extension
Modified paths:
  • /trunk/extensions/UnitTest (added) (history)

Diff [purge]

Follow-up revisions

RevisionCommit summaryAuthorDate
r109763Adding UnitTest Extension. See r109762.jpostlethwaite21:47, 22 January 2012
r109764Adding UnitTest Extension. See r109762.jpostlethwaite21:48, 22 January 2012
r109765Adding UnitTest Extension. See r109762.jpostlethwaite21:53, 22 January 2012
r109767Adding UnitTest Extension. See r109762.jpostlethwaite21:55, 22 January 2012
r109768Adding UnitTest Extension. See r109762.jpostlethwaite21:57, 22 January 2012
r109769Adding UnitTest Extension. See r109762.jpostlethwaite21:59, 22 January 2012
r109771Removing TestConfiguration.php, this should not be checked in. See r109762.jpostlethwaite22:07, 22 January 2012
r109772Removing symlink for unittest.sh. See r109762.jpostlethwaite22:09, 22 January 2012
r109773Adding unittest.sh. See r109762.jpostlethwaite22:10, 22 January 2012
r109828Adding the jquery cycle plugin. This is being used by the UnitTest extension....jpostlethwaite16:13, 23 January 2012

Comments

#Comment by Reedy (talk | contribs)   22:49, 22 January 2012

Can we rename this? Calling it UnitTest is quite vague, and even more so with us having unit tests in core...

#Comment by Jpostlethwaite (talk | contribs)   23:24, 22 January 2012

I do not mind renaming it, but it would be best if we did it now before it gets put into use.

I will be working with mglaser to merge this with the core unit testing -- of course we need to get other developer input as well :)

If we did that, renaming might be moot.

#Comment by Reedy (talk | contribs)   23:26, 22 January 2012

I was half wondering why it wasn't in core

Any idea on timescale? If it's going to be a while (obviously not before 1.19 is branched), renaming would probably have some use, if it's not going to be that long, like you say, probably not much point in doing so

#Comment by Jpostlethwaite (talk | contribs)   23:53, 22 January 2012

We just got two virtual machines in labs yesterday to get this rolling.

I would like to get this in as fast as possible :)

Alolita asked me to get this running on four extensions: Webfonts, Narayam, Babel and Translate.

#Comment by Johnduhart (talk | contribs)   18:26, 23 January 2012

What does this do that unittests in core don't?

#Comment by Reedy (talk | contribs)   18:45, 23 January 2012

The followup commits look more selenium esk

#Comment by Jpostlethwaite (talk | contribs)   19:06, 23 January 2012

I just updated the extension page:

https://www.mediawiki.org/wiki/Extension:UnitTest

I will be updating that page this week.

Status & tagging log