r109715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109714‎ | r109715 | r109716 >
Date:02:06, 22 January 2012
Author:varnent
Status:deferred (Comments)
Tags:
Comment:
better backwards compatibility to MW1.17
Modified paths:
  • /trunk/extensions/AddThis/AddThis.body.php (modified) (history)
  • /trunk/extensions/AddThis/RELEASE+NOTES (modified) (history)

Diff [purge]

Index: trunk/extensions/AddThis/AddThis.body.php
@@ -64,7 +64,8 @@
6565 # Check if page is in content namespace and the setting to enable/disable article header tooblar either on the main page or at all
6666 if ( !MWNamespace::isContent( $article->getTitle()->getNamespace() )
6767 || !$wgAddThisHeader
68 - || ( $article->getTitle()->isMainPage() && !$wgAddThisMain )
 68+ || ( ($article->getTitle()->getText() == wfMsg('mainpage') ) && !$wgAddThisMain )
 69+
6970 ) {
7071 return true;
7172 }
Index: trunk/extensions/AddThis/RELEASE NOTES
@@ -1,2 +1,2 @@
22 For the latest release notes, please see:
3 -http://www.mediawiki.org/wiki/Extension:AddThis#Release_notes
\ No newline at end of file
 3+https://www.mediawiki.org/wiki/Extension:AddThis#Release_notes
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r109801fix to r109715 - ty Nikerabbit & Reedyvarnent02:53, 23 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   10:07, 22 January 2012

That's not correct. Use Title::equals( Title::newMainPage() ).

#Comment by Varnent (talk | contribs)   23:13, 22 January 2012

I'm not having any luck getting Title::equals( Title::newMainPage() ) to work - but playing around a bit still..

Status & tagging log