r109661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109660‎ | r109661 | r109662 >
Date:23:18, 20 January 2012
Author:seanheavey
Status:resolved (Comments)
Tags:
Comment:
Final styles for Jan. 20 push to prototype.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
——@@ -2,38 +2,48 @@
33 /*div.articleFeedbackv5-feedback { border:1px solid #CCC; background:#EEE; margin-top:10px; clear:both;}
44 div.articleFeedbackv5-feedback-tools { border:1px solid #CCD; background:#EEF; margin:10px; width:219px; float:right;}*/
55 /*----- FEEDBACK PAGE ------*/
 6+.float-clear {
 7+ clear: both;
 8+ height: 0;
 9+}
610 .float-clear:after {
711 clear: both;
812 }
 13+#articleFeedbackv5-header-wrap {
 14+ margin: 0 0 10px;
 15+}
 16+#articleFeedbackv5-header-wrap:after {
 17+ clear: both;
 18+}
919 #articleFeedbackv5-header-links {
1020 float: right;
1121 }
12 -#articleFeedbackv5-percent-found-wrap {
 22+#articleFeedbackv5-showing-count-wrap {
1323 float: left;
 24+ margin: 0 0 5px;
1425 }
15 -#articleFeedbackv5-showing-count-wrap {
16 - clear: both;
17 - float: right;
18 - display: none;
19 -}
2026 #articleFeedbackv5-percent-found-wrap {
 27+ clear: left;
 28+ font-size: 1.5em;
 29+ line-height: 35px;
2130 float: left;
2231 }
2332 #articleFeedbackv5-percent-found-wrap .stat-marker {
2433 display: inline-block;
25 - background: #2f8035;
2634 color: #fff;
2735 -webkit-border-radius: 5px;
2836 -moz-border-radius: 5px;
 37+ -ms-border-radius: 5px;
2938 border-radius: 5px;
30 - width: 45px;
31 - height: 30px;
32 - line-height: 35px;
 39+ padding: 0 5px 0 30px;
3340 text-align: center;
3441 }
35 -.aftv5-feedbackpage .aftv5-feedbackpage-new-feedback {
36 - float: right;
 42+#articleFeedbackv5-percent-found-wrap .positive {
 43+ background: #2f8035 url(images/bg_emoticon_positive.png) no-repeat 5px center;
3744 }
 45+#articleFeedbackv5-percent-found-wrap .negative {
 46+ background: #bf0a0a url(images/bg_emoticon_negative.png) no-repeat 5px center;
 47+}
3848 .aftv5-feedbackpage .aftv5-feedbackpage-comment-display-header {
3949 height: 40px;
4050 background: url(images/bg-feedbackpage-header.png) repeat-x;
——@@ -43,6 +53,7 @@
4454 clear: both;
4555 }
4656 #articleFeedbackv5-sort-filter-controls {
 57+ clear: both;
4758 padding: 0 10px;
4859 height: 40px;
4960 line-height: 40px;
——@@ -55,7 +66,7 @@
5667 float: left;
5768 margin: 0 50px 0 0;
5869 }
59 -#articleFeedbackv5-sort-filter-controls #articleFeedbackv5-filter {
 70+#articleFeedbackv5-filter-select {
6071 position: relative;
6172 top: 10px;
6273 float: none;
——@@ -78,12 +89,18 @@
7990 .articleFeedbackv5-comment-wrap {
8091 float: left;
8192 }
 93+.articleFeedbackv5-comment-wrap h3 .positive {
 94+ color: #2f8035;
 95+}
 96+.articleFeedbackv5-comment-wrap h3 .negative {
 97+ color: #bf0a0a;
 98+}
8299 .articleFeedbackv5-feedback .articleFeedbackv5-feedback-tools {
83100 display: none;
84101 position: absolute;
85102 top: 0;
86103 right: 10px;
87 - width: 210px;
 104+ width: 140px;
88105 }
89106 .articleFeedbackv5-feedback .articleFeedbackv5-feedback-tools h3 {
90107 background: #3366bb;
——@@ -99,7 +116,7 @@
100117 text-align: center;
101118 position: absolute;
102119 z-index: 150;
103 - width: 210px;
 120+ width: 140px;
104121 margin: 0;
105122 cursor: pointer;
106123 }
——@@ -148,45 +165,22 @@
149166 float: right;
150167 }
151168 #articleFeedbackv5-special-add-feedback {
152 - -webkit-box-shadow:#999999 -2px 2px 1px;
153 - background-attachment:initial !important;
154 - background-clip:initial !important;
155 - background-color:initial !important;
156 - background-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAAjCAIAAADaE/fjAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyRpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYxIDY0LjE0MDk0OSwgMjAxMC8xMi8wNy0xMDo1NzowMSAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNS4xIE1hY2ludG9zaCIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDo4QzkwMjE1MjE0RTExMUUxQTkyM0IxNzE3N0RFODgwNiIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDo4MTMwRTQxMjE0RTIxMUUxQTkyM0IxNzE3N0RFODgwNiI+IDx4bXBNTTpEZXJpdmVkRnJvbSBzdFJlZjppbnN0YW5jZUlEPSJ4bXAuaWlkOjhDOTAyMTUwMTRFMTExRTFBOTIzQjE3MTc3REU4ODA2IiBzdFJlZjpkb2N1bWVudElEPSJ4bXAuZGlkOjhDOTAyMTUxMTRFMTExRTFBOTIzQjE3MTc3REU4ODA2Ii8+IDwvcmRmOkRlc2NyaXB0aW9uPiA8L3JkZjpSREY+IDwveDp4bXBtZXRhPiA8P3hwYWNrZXQgZW5kPSJyIj8+OdQuLwAAAEFJREFUeNpcjcENACAIAysrOZNLuputoWo0vi5HKaC2HpBCUBSTdoieOROXPyzmzaCxfTy7XzfvMbm6SVDnzxRgACWnTTX5Rk3FAAAAAElFTkSuQmCC) !important;
157 - background-origin:initial !important;
158 - background-position:initial initial !important;
159 - background-repeat:repeat no-repeat !important;
160 - border-bottom-left-radius:3px;
161 - border-bottom-right-radius:3px;
162 - border-bottom-style:none !important;
163 - border-color:initial !important;
164 - border-image:initial !important;
165 - border-left-style:none !important;
166 - border-right-style:none !important;
167 - border-top-left-radius:3px;
168 - border-top-right-radius:3px;
169 - border-top-style:none !important;
170 - border-width:initial !important;
171 - box-shadow:#999999 -2px 2px 1px;
172 - background-attachment:scroll !important;
173 - background-clip:initial !important;
174 - background-color:#407EC9 !important;
175 - background-origin:initial !important;
176 - background-position:50% 100% !important;
177 - background-repeat:repeat no-repeat !important;
178 - border-bottom-color:#407EC9 !important;
179 - border-left-color:#407EC9 !important;
180 - border-right-color:#407EC9 !important;
181 - border-top-color:#407EC9 !important;
182 - color:white;
183 - display: block;
184 - width: auto;
185 - height: 35px;
186 - line-height: 35px;
187 - padding: 0 9px;
188 -
189 - float: right;
 169+ color:white;
 170+ display: block;
 171+ -webkit-border-radius: 5px;
 172+ -moz-border-radius: 5px;
 173+ -ms-border-radius: 5px;
 174+ border-radius: 5px;
 175+ width: auto;
 176+ height: 35px;
 177+ line-height: 35px;
 178+ padding: 0 9px;
 179+ float: right;
 180+ background: url(images/bg-submit.png) repeat-x;
190181 }
 182+#articleFeedbackv5-special-add-feedback:after {
 183+ clear:both;
 184+}
191185 #articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot {
192186 line-height: 22px;
193187 }

Comments

#Comment by Johnduhart (talk | contribs)   23:54, 20 January 2012

You're missing embeds for resource loader.

#Comment by Rsterbin (talk | contribs)   00:36, 31 January 2012

These are fixed now, but I don't think Sean has the right permissions to set this back to new. Doing that now.

Status & tagging log