r109646 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109645‎ | r109646 | r109647 >
Date:21:03, 20 January 2012
Author:seanheavey
Status:resolved (Comments)
Tags:aft 
Comment:
further development .css for feedback page. new icons added as well.
Modified paths:
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_negative.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_positive.png (added) (history)
  • /trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_positive.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_positive.png
___________________________________________________________________
Added: svn:mime-type
11 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_negative.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/images/bg_emoticon_negative.png
___________________________________________________________________
Added: svn:mime-type
22 + application/octet-stream
Index: trunk/extensions/ArticleFeedbackv5/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.css
@@ -16,10 +16,10 @@
1717 float: right;
1818 display: none;
1919 }
20 -#aftv5-feedbackpage .aftv5-feedbackpage-statistics {
 20+#articleFeedbackv5-percent-found-wrap {
2121 float: left;
2222 }
23 -.aftv5-feedbackpage .aftv5-feedbackpage-statistics .stat-marker {
 23+#articleFeedbackv5-percent-found-wrap .stat-marker {
2424 display: inline-block;
2525 background: #2f8035;
2626 color: #fff;
@@ -46,7 +46,7 @@
4747 padding: 0 10px;
4848 height: 40px;
4949 line-height: 40px;
50 - background: url(images/bg-feedbackpage-header.png) repeat-x;
 50+ background: #D2E5F7;
5151 }
5252 #articleFeedbackv5-sort-filter-controls:after {
5353 clear: both;
@@ -56,35 +56,41 @@
5757 margin: 0 50px 0 0;
5858 }
5959 #articleFeedbackv5-sort-filter-controls #articleFeedbackv5-filter {
60 - float: left;
61 -}v
62 -#articleFeedbackv5-sort-filter-controls select {
6360 position: relative;
6461 top: 10px;
 62+ float: none;
 63+ display: inline-block;
6564 }
6665 #articleFeedbackv5-show-feedback {
6766 overflow: scroll;
68 - height: 600px;
 67+ height: 750px;
6968 }
7069 .articleFeedbackv5-feedback {
 70+ min-width: 650px;
7171 position: relative;
7272 padding: 10px 10px 09px;
7373 border-bottom: 1px solid #d6d6d6;
7474 overflow: hidden;
7575 }
 76+.articleFeedbackv5-feedback:after {
 77+ clear: both;
 78+}
 79+.articleFeedbackv5-comment-wrap {
 80+ float: left;
 81+}
7682 .articleFeedbackv5-feedback .articleFeedbackv5-feedback-tools {
7783 display: none;
7884 position: absolute;
7985 top: 0;
80 - right: 20px;
81 - width: 140px;
 86+ right: 10px;
 87+ width: 210px;
8288 }
8389 .articleFeedbackv5-feedback .articleFeedbackv5-feedback-tools h3 {
8490 background: #3366bb;
8591 -moz-border-radius-bottomright: 5px;
8692 -moz-border-radius-bottomleft: 5px;
87 - -webkit-border-radius-bottomleft: 5px;
88 - -webkit-border-radius-bottomright: 5px;
 93+ -webkit-border-bottom-right-radius: 5px;
 94+ -webkit-border-bottom-left-radius: 5px;
8995 -ms-border-radius-bottomleft: 5px;
9096 -ms-border-radius-bottomright: 5px;
9197 border-radius-bottomleft: 5px;
@@ -93,7 +99,7 @@
94100 text-align: center;
95101 position: absolute;
96102 z-index: 150;
97 - width: 140px;
 103+ width: 210px;
98104 margin: 0;
99105 cursor: pointer;
100106 }
@@ -103,8 +109,8 @@
104110 background: #d2e5f7;
105111 -moz-border-radius-bottomright: 5px;
106112 -moz-border-radius-bottomleft: 5px;
107 - -webkit-border-radius-bottomleft: 5px;
108 - -webkit-border-radius-bottomright: 5px;
 113+ -webkit-border-bottom-right-radius: 5px;
 114+ -webkit-border-bottom-left-radius: 5px;
109115 -ms-border-radius-bottomleft: 5px;
110116 -ms-border-radius-bottomright: 5px;
111117 border-radius-bottomleft: 5px;
@@ -135,11 +141,11 @@
136142 background: #d2e5f7;
137143 }
138144 .articleFeedbackv5-feedback blockquote {
139 - float: left;
 145+ margin: 10px 0;
 146+ padding: 0;
140147 }
141148 .articleFeedbackv5-feedback .articleFeedbackv5-comment-details {
142149 float: right;
143 - clear: both;
144150 }
145151 #articleFeedbackv5-special-add-feedback {
146152 -webkit-box-shadow:#999999 -2px 2px 1px;
@@ -180,4 +186,49 @@
181187 padding: 0 9px;
182188
183189 float: right;
184 -}
\ No newline at end of file
 190+}
 191+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot {
 192+ line-height: 22px;
 193+}
 194+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-helpful-caption {
 195+ margin: 0 10px 0 0;
 196+}
 197+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-helpful-link,
 198+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-unhelpful-link {
 199+ display: inline-block;
 200+ height: 22px;
 201+ line-height: 22px;
 202+ font-size: .9em;
 203+ min-width: 34px;
 204+ padding: 0 8px;
 205+ margin: 0 10px 0 0;
 206+ text-align: center;
 207+ color: #333;
 208+ font-weight: bold;
 209+ /* @embed */
 210+ background: url(images/bg-button-disable.png) repeat-x;
 211+ -moz-border-radius: 3px;
 212+ -webkit-border-radius: 3px;
 213+ border-radius: 3px; /* future proofing */
 214+ -khtml-border-radius: 3px; /* for old Konqueror browsers */
 215+ -moz-box-shadow: -2px 2px 1px #999;
 216+ -webkit-box-shadow: -2px 2px 1px #999;
 217+ box-shadow: -2px 2px 1px #999;
 218+}
 219+
 220+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-helpful-link:hover,
 221+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-unhelpful-link:hover {
 222+ /* @embed */
 223+ background: url(images/bg-button-hov.png) repeat-x;
 224+ cursor: pointer;
 225+ color: #333;
 226+}
 227+
 228+/*#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-helpful-link-active,
 229+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-unhelpful-link-active,
 230+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-helpful-link-active:hover,
 231+#articleFeedbackv5-show-feedback .articleFeedbackv5-comment-foot .articleFeedbackv5-unhelpful-link-active:hover {
 232+ /* @embed */
 233+ /*background: url(images/bg-button.png) repeat-x;
 234+ color: #fff;
 235+}*/
\ No newline at end of file

Follow-up revisions

RevisionCommit summaryAuthorDate
r109854Fix image mime-type from r109646reedy21:49, 23 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   19:12, 23 January 2012

Missing /* @embed */s

#Comment by Rsterbin (talk | contribs)   00:35, 31 January 2012

These are fixed now, but I don't think Sean has the right permissions to set this back to new. Doing that now.

Status & tagging log