r109547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109546‎ | r109547 | r109548 >
Date:16:37, 19 January 2012
Author:reedy
Status:resolved
Tags:
Comment:
* (bug 33819) Display filesize on Special:NewFiles in appropriate unit.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -228,6 +228,7 @@
229229 of whatever the query value contains.
230230 * (bug 4438) Add CSS hook for current WikiPage action.
231231 * (bug 33703) Common border-bottom color for <abbr> should inherit default (text) color
 232+* (bug 33819) Display filesize on Special:NewFiles in appropriate unit.
232233
233234 === API changes in 1.19 ===
234235 * Made action=edit less likely to return "unknownerror", by returning the actual error
Index: trunk/phase3/includes/ImageGallery.php
@@ -314,8 +314,7 @@
315315
316316 if( $this->mShowBytes ) {
317317 if( $img ) {
318 - $fileSize = wfMsgExt( 'nbytes', array( 'parsemag', 'escape'),
319 - $wgLang->formatNum( $img->getSize() ) );
 318+ $fileSize = $wgLang->formatSize( $img->getSize() );
320319 } else {
321320 $fileSize = wfMsgHtml( 'filemissing' );
322321 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r109548Like r109547, display file size in appropriate units on mimesearchreedy16:41, 19 January 2012
r109549* (bug 33819) Display filesize on Special:NewFiles in appropriate unit....reedy16:44, 19 January 2012
r109550Add some escaping to r109547, 109548, 109549...reedy16:55, 19 January 2012

Status & tagging log