r109418 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109417‎ | r109418 | r109419 >
Date:18:20, 18 January 2012
Author:siebrand
Status:ok
Tags:backcompat 
Comment:
Remove support for the deprecated and no longer used in trunk hook MagicWordMagicWords.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/MagicWord.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1264,11 +1264,6 @@
12651265 'MaintenanceRefreshLinksInit': before executing the refreshLinks.php maintenance script
12661266 $refreshLinks: RefreshLinks object
12671267
1268 -'MagicWordMagicWords': When defining new magic word.
1269 -DEPRECATED: use $magicWords in a file listed in
1270 -$wgExtensionMessagesFiles instead.
1271 -$magicWords: array of strings
1272 -
12731268 'MagicWordwgVariableIDs': When definig new magic words IDs.
12741269 $variableIDs: array of strings
12751270
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -302,7 +302,8 @@
303303 methods have been removed, the variant is now part of the $query argument.
304304 * Removed Title::isValidCssJsSubpage(), deprecated since 1.17 in favor of
305305 using Title::isCssJsSubpage() or checking Title::isWrongCaseCssJsPage().
306 -* (bug 24430) Remove number of column for edit field in preference page
 306+* (bug 24430) Remove number of column for edit field in preference page.
 307+* Support for the deprecated hook MagicWordMagicWords was removed.
307308
308309 == Compatibility ==
309310
Index: trunk/phase3/includes/MagicWord.php
@@ -223,13 +223,6 @@
224224 */
225225 static function getVariableIDs() {
226226 if ( !self::$mVariableIDsInitialised ) {
227 - # Deprecated constant definition hook, available for extensions that need it
228 - $magicWords = array();
229 - wfRunHooks( 'MagicWordMagicWords', array( &$magicWords ) );
230 - foreach ( $magicWords as $word ) {
231 - define( $word, $word );
232 - }
233 -
234227 # Get variable IDs
235228 wfRunHooks( 'MagicWordwgVariableIDs', array( &self::$mVariableIDs ) );
236229 self::$mVariableIDsInitialised = true;

Sign-offs

UserFlagDate
Nikerabbitinspected08:59, 19 January 2012

Status & tagging log