r109417 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109416‎ | r109417 | r109418 >
Date:18:17, 18 January 2012
Author:yaron
Status:ok
Tags:
Comment:
Follow-up to r109165 - added 'static' declarations to remaining methods
Modified paths:
  • /trunk/extensions/DataTransfer/specials/DT_ViewXML.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DataTransfer/specials/DT_ViewXML.php
@@ -45,7 +45,7 @@
4646 return $categories;
4747 }
4848
49 - function getNamespacesList() {
 49+ static function getNamespacesList() {
5050 $dbr = wfGetDB( DB_SLAVE );
5151 $page = $dbr->tableName( 'page' );
5252 $res = $dbr->query( "SELECT DISTINCT page_namespace FROM $page" );
@@ -57,7 +57,7 @@
5858 return $namespaces;
5959 }
6060
61 - function getGroupings() {
 61+ static function getGroupings() {
6262 global $dtgContLang, $smwgIP;
6363
6464 if ( ! isset( $smwgIP ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109165Added compatibility for SMW 1.6 (finally), moved all functions into class, pl...yaron17:28, 17 January 2012

Status & tagging log