r109358 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109357‎ | r109358 | r109359 >
Date:12:57, 18 January 2012
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
Open the Narayam help page in new tab/window.
Modified paths:
  • /trunk/extensions/Narayam/resources/ext.narayam.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Narayam/resources/ext.narayam.core.js
@@ -619,7 +619,8 @@
620620 if ( helppage ) {
621621 var $link = $( '<a>' )
622622 .text( mw.msg( 'narayam-help' ) )
623 - .prop( 'href', helppage );
 623+ .prop( 'href', helppage )
 624+ .prop( 'target', '_blank' );
624625 var $li = $( '<li>' ).addClass( 'narayam-help-link' );
625626 $narayamMenuItems.append( $li.append( $link ) );
626627 }

Sign-offs

UserFlagDate
Nikerabbitinspected07:39, 19 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r109027Point the Narayam help link to the https://www.mediawiki.org/wiki/Help:Extens......santhosh11:29, 16 January 2012

Comments

#Comment by Siebrand (talk | contribs)   14:51, 18 January 2012

Follow-up to r109027

Status & tagging log