r109142 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r109141‎ | r109142 | r109143 >
Date:13:23, 17 January 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Bump 0.61
Modified paths:
  • /trunk/extensions/TweetANew/lib/tmhOAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TweetANew/lib/tmhOAuth.php
@@ -7,12 +7,12 @@
88 * REST requests. OAuth authentication is sent using the an Authorization Header.
99 *
1010 * @author themattharris
11 - * @version 0.60
 11+ * @version 0.61
1212 *
13 - * 29 December 2011
 13+ * 16 January 2012
1414 */
1515 class tmhOAuth {
16 - const VERSION = 0.60;
 16+ const VERSION = 0.61;
1717
1818 /**
1919 * Creates a new tmhOAuth object
@@ -52,8 +52,9 @@
5353 'curl_connecttimeout' => 30,
5454 'curl_timeout' => 10,
5555
56 - // for security these should always be set to true.
57 - 'curl_ssl_verifyhost' => true,
 56+ // for security this should always be set to 2.
 57+ 'curl_ssl_verifyhost' => 2,
 58+ // for security this should always be set to true.
5859 'curl_ssl_verifypeer' => true,
5960
6061 // you can get the latest cacert.pem from here http://curl.haxx.se/ca/cacert.pem
@@ -652,4 +653,4 @@
653654 $this->response['errno'] = $errno;
654655 return $code;
655656 }
656 -}
 657+}
\ No newline at end of file

Comments

#Comment by Nikerabbit (talk | contribs)   15:15, 17 January 2012

Haven't seen such useless comment for a while as this.

// for security meaning_of_life should always be set to 42.

Status & tagging log