r109131 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r109130‎ | r109131 | r109132 >
Date:10:13, 17 January 2012
Author:neilk
Status:ok
Tags:
Comment:
fixed quoting, commenting issues that seem to confuse sql.php. INSERT INTO -> REPLACE INTO
Modified paths:
  • /trunk/extensions/CongressLookup/data/cl_house.sql (modified) (history)
  • /trunk/extensions/CongressLookup/data/cl_senate.sql (modified) (history)
  • /trunk/extensions/CongressLookup/data/cl_zip3.sql (modified) (history)
  • /trunk/extensions/CongressLookup/data/cl_zip5.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/CongressLookup/data/cl_house.sql
——@@ -1,25 +1,4 @@
2 -
3 -SET SQL_MODE="NO_AUTO_VALUE_ON_ZERO";
4 -
5 -
6 -/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
7 -/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
8 -/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
9 -/*!40101 SET NAMES utf8 */;
10 -
11 -
12 -INSERT INTO /*$wgDBprefix*/`cl_house` (`clh_id`, `clh_bioguideid`, `clh_gender`, `clh_name`, `clh_title`, `clh_state`, `clh_district`, `clh_phone`, `clh_fax`, `clh_contactform`, `clh_twitter`) VALUES
 2+REPLACE INTO /*$wgDBprefix*/cl_house (`clh_id`, `clh_bioguideid`, `clh_gender`, `clh_name`, `clh_title`, `clh_state`, `clh_district`, `clh_phone`, `clh_fax`, `clh_contactform`, `clh_twitter`) VALUES
133 (400003, 'A000022', 'M', 'Rep. Gary Ackerman [D, NY-5]', 'Rep.', 'NY', '5', '202-225-2601', '202-225-1589', 'http://www.house.gov/writerep', NULL),
144 (400004, 'A000055', 'M', 'Rep. Robert Aderholt [R, AL-4]', 'Rep.', 'AL', '4', '202-225-4876', '202-225-5587', 'http://aderholt.house.gov/?sectionid=195&sectiontree=195', 'Robert_Aderholt'),
155 (400005, 'A000358', 'M', 'Rep. Todd Akin [R, MO-2]', 'Rep.', 'MO', '2', '202-225-2561', '202-225-2563', 'http://akin.house.gov/email.shtml', 'ToddAkin'),
——@@ -314,7 +293,7 @@
315294 (412228, 'S001174', 'F', 'Rep. Betty Sutton [D, OH-13]', 'Rep.', 'OH', '13', '202-225-3401', '202-225-2266', 'http://sutton.house.gov/about/emailform.cfm', NULL),
316295 (412231, 'A000362', 'M', 'Rep. Jason Altmire [D, PA-4]', 'Rep.', 'PA', '4', '202-225-2565', '202-226-2274', 'https://forms.house.gov/altmire/webforms/issue_subscribe.htm', NULL),
317296 (412236, 'C001068', 'M', 'Rep. Steve Cohen [D, TN-9]', 'Rep.', 'TN', '9', '202-225-3265', '202-225-5663', 'http://cohen.house.gov/index.php?option=com_email_form&Itemid=113', 'RepCohen');
318 -INSERT INTO /*$wgDBprefix*/`cl_house` (`clh_id`, `clh_bioguideid`, `clh_gender`, `clh_name`, `clh_title`, `clh_state`, `clh_district`, `clh_phone`, `clh_fax`, `clh_contactform`, `clh_twitter`) VALUES
 297+REPLACE INTO /*$wgDBprefix*/cl_house (`clh_id`, `clh_bioguideid`, `clh_gender`, `clh_name`, `clh_title`, `clh_state`, `clh_district`, `clh_phone`, `clh_fax`, `clh_contactform`, `clh_twitter`) VALUES
319298 (412239, 'W000800', 'M', 'Rep. Peter Welch [D, VT-0]', 'Rep.', 'VT', '0', '202-225-4115', '202-225-6790', 'http://www.house.gov/formwelch/issue_subscribe.htm', NULL),
320299 (412250, 'B001257', 'M', 'Rep. Gus Bilirakis [R, FL-9]', 'Rep.', 'FL', '9', '202-225-5755', '202-225-4085', 'http://bilirakis.house.gov/index.php?option=com_content&task=view&id=212&Itemid=44', 'RepGusBilirakis'),
321300 (412252, 'B001262', 'M', 'Rep. Paul Broun [R, GA-10]', 'Rep.', 'GA', '10', '202-225-4101', '202-226-0776', 'http://broun.house.gov/email.shtml', 'RepPaulBrounMD'),
Index: trunk/extensions/CongressLookup/data/cl_zip3.sql
——@@ -1,25 +1,4 @@
2 -
3 -SET SQL_MODE="NO_AUTO_VALUE_ON_ZERO";
4 -
5 -
6 -/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
7 -/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
8 -/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
9 -/*!40101 SET NAMES utf8 */;
10 -
11 -
12 -INSERT INTO /*$wgDBprefix*/`cl_zip3` (`clz3_zip`, `clz3_state`) VALUES
 2+REPLACE INTO /*$wgDBprefix*/cl_zip3 (`clz3_zip`, `clz3_state`) VALUES
133 (5, 'NY'),
144 (6, 'PR'),
155 (7, 'PR'),
Index: trunk/extensions/CongressLookup/data/cl_zip5.sql
——@@ -1,24 +1,3 @@
2 -
3 -SET SQL_MODE="NO_AUTO_VALUE_ON_ZERO";
4 -
5 -
6 -/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
7 -/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
8 -/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
9 -/*!40101 SET NAMES utf8 */;
10 -
11 -
122 REPLACE INTO /*$wgDBprefix*/cl_zip5 (`clz5_zip`, `clz5_rep_id`) VALUES
133 (501, 400031),
144 (544, 400031),
Index: trunk/extensions/CongressLookup/data/cl_senate.sql
——@@ -1,25 +1,4 @@
2 -
3 -SET SQL_MODE="NO_AUTO_VALUE_ON_ZERO";
4 -
5 -
6 -/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
7 -/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
8 -/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
9 -/*!40101 SET NAMES utf8 */;
10 -
11 -
12 -INSERT INTO /*$wgDBprefix*/`cl_senate` (`cls_id`, `cls_bioguideid`, `cls_gender`, `cls_name`, `cls_title`, `cls_state`, `cls_phone`, `cls_fax`, `cls_contactform`, `cls_twitter`) VALUES
 2+REPLACE INTO /*$wgDBprefix*/cl_senate (`cls_id`, `cls_bioguideid`, `cls_gender`, `cls_name`, `cls_title`, `cls_state`, `cls_phone`, `cls_fax`, `cls_contactform`, `cls_twitter`) VALUES
133 (300001, 'A000069', 'M', 'Sen. Daniel Akaka [D, HI]', 'Sen.', 'HI', '202-224-6361', '202-224-2126', 'http://www.akaka.senate.gov/email-senator-akaka.cfm', NULL),
144 (300002, 'A000360', 'M', 'Sen. Lamar Alexander [R, TN]', 'Sen.', 'TN', '202-224-4944', '202-228-3398', 'http://www.alexander.senate.gov/public/index.cfm?p=Email', 'SenAlexander'),
155 (300005, 'B000243', 'M', 'Sen. Max Baucus [D, MT]', 'Sen.', 'MT', '202-224-2651', '202-224-0515', 'http://www.baucus.senate.gov/contact/emailForm.cfm?subj=issue', NULL),

Follow-up revisions

RevisionCommit summaryAuthorDate
r109132MFT r109128, r109131 -- various fixes, improvements to sql data filesneilk10:17, 17 January 2012

Status & tagging log