r108961 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108960‎ | r108961 | r108962 >
Date:06:15, 15 January 2012
Author:johnduhart
Status:resolved (Comments)
Tags:
Comment:
Adding note about jquery.arrowSteps being added to core, ping r108960
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizardHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizardHooks.php
@@ -37,7 +37,7 @@
3838 // jquery interface helpers
3939 'resources/jquery/jquery.morphCrossfade.js',
4040 'resources/jquery/jquery.validate.js', // In trunk as of 1.19
41 - 'resources/jquery/jquery.arrowSteps.js',
 41+ 'resources/jquery/jquery.arrowSteps.js', // In trunk as of 1.19
4242 'resources/jquery/jquery.autocomplete.js',
4343 'resources/jquery/jquery.spinner.js', // In trunk as of 1.19
4444 'resources/jquery/jquery.removeCtrl.js',
@@ -115,41 +115,41 @@
116116 'mwe-upwiz-step-deeds',
117117 'mwe-upwiz-step-details',
118118 'mwe-upwiz-step-thanks',
119 - 'api-error-http',
120 - 'api-error-ok-but-empty',
121 - 'api-error-unknown-code',
122 - 'api-error-uploaddisabled',
123 - 'api-error-nomodule',
124 - 'api-error-mustbeposted',
125 - 'api-error-badaccess-groups',
126 - 'api-error-stashfailed',
127 - 'api-error-missingresult',
128 - 'api-error-missingparam',
129 - 'api-error-invalid-file-key',
130 - 'api-error-copyuploaddisabled',
131 - 'api-error-mustbeloggedin',
132 - 'api-error-empty-file',
133 - 'api-error-file-too-large',
134 - 'api-error-filetype-missing',
135 - 'api-error-filetype-banned',
136 - 'api-error-filename-tooshort',
137 - 'api-error-illegal-filename',
138 - 'api-error-verification-error',
139 - 'api-error-hookaborted',
140 - 'api-error-unknown-error',
141 - 'api-error-internal-error',
142 - 'api-error-overwrite',
143 - 'api-error-badtoken',
144 - 'api-error-fetchfileerror',
145 - 'api-error-duplicate',
146 - 'api-error-duplicate-popup-title',
147 - 'api-error-duplicate-archive',
148 - 'api-error-duplicate-archive-popup-title',
149 - 'api-error-unknown-warning',
150 - 'api-error-timeout',
151 - 'api-error-noimageinfo',
152 - 'api-error-fileexists-shared-forbidden',
153 - 'api-error-unclassified',
 119+ 'mwe-upwiz-api-error-http',
 120+ 'mwe-upwiz-api-error-ok-but-empty',
 121+ 'mwe-upwiz-api-error-unknown-code',
 122+ 'mwe-upwiz-api-error-uploaddisabled',
 123+ 'mwe-upwiz-api-error-nomodule',
 124+ 'mwe-upwiz-api-error-mustbeposted',
 125+ 'mwe-upwiz-api-error-badaccess-groups',
 126+ 'mwe-upwiz-api-error-stashfailed',
 127+ 'mwe-upwiz-api-error-missingresult',
 128+ 'mwe-upwiz-api-error-missingparam',
 129+ 'mwe-upwiz-api-error-invalid-file-key',
 130+ 'mwe-upwiz-api-error-copyuploaddisabled',
 131+ 'mwe-upwiz-api-error-mustbeloggedin',
 132+ 'mwe-upwiz-api-error-empty-file',
 133+ 'mwe-upwiz-api-error-file-too-large',
 134+ 'mwe-upwiz-api-error-filetype-missing',
 135+ 'mwe-upwiz-api-error-filetype-banned',
 136+ 'mwe-upwiz-api-error-filename-tooshort',
 137+ 'mwe-upwiz-api-error-illegal-filename',
 138+ 'mwe-upwiz-api-error-verification-error',
 139+ 'mwe-upwiz-api-error-hookaborted',
 140+ 'mwe-upwiz-api-error-unknown-error',
 141+ 'mwe-upwiz-api-error-internal-error',
 142+ 'mwe-upwiz-api-error-overwrite',
 143+ 'mwe-upwiz-api-error-badtoken',
 144+ 'mwe-upwiz-api-error-fetchfileerror',
 145+ 'mwe-upwiz-api-error-duplicate',
 146+ 'mwe-upwiz-api-error-duplicate-popup-title',
 147+ 'mwe-upwiz-api-error-duplicate-archive',
 148+ 'mwe-upwiz-api-error-duplicate-archive-popup-title',
 149+ 'mwe-upwiz-api-error-unknown-warning',
 150+ 'mwe-upwiz-api-error-timeout',
 151+ 'mwe-upwiz-api-error-noimageinfo',
 152+ 'mwe-upwiz-api-error-fileexists-shared-forbidden',
 153+ 'mwe-upwiz-api-error-unclassified',
154154 'mwe-upwiz-api-warning-was-deleted',
155155 'mwe-upwiz-api-warning-exists',
156156 'mwe-upwiz-tutorial-error-localized-file-missing',

Follow-up revisions

RevisionCommit summaryAuthorDate
r109040Remove the seemingly unexpected changes from r108961...reedy15:25, 16 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108960Adding jquery.arrowSteps to core, from UploadWizardjohnduhart06:07, 15 January 2012

Comments

#Comment by Siebrand (talk | contribs)   10:38, 15 January 2012

This commit appears to change more than what the commit summary implies. Could it be that you hadn't updated your code before committing?

Status & tagging log