r108954 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108953‎ | r108954 | r108955 >
Date:05:01, 15 January 2012
Author:oren
Status:ok (Comments)
Tags:
Comment:
fixed some typos
Modified paths:
  • /trunk/lucene-search-2/src/org/wikimedia/lsearch/config/IndexId.java (modified) (history)

Diff [purge]

Index: trunk/lucene-search-2/src/org/wikimedia/lsearch/config/IndexId.java
@@ -15,7 +15,7 @@
1616 import org.wikimedia.lsearch.search.SearcherCache;
1717
1818 /**
19 - * Encapsulated an index ID in form db.part, e.g. entest.mainpart.
 19+ * IndexId encapsulate an index ID in form db.part, e.g. entest.mainpart.
2020 * It identifies each index part in the system. If entest is the name
2121 * of the database, and it uses mainsplit architecture, there will be
2222 * three IndexIds: <br/>
@@ -30,14 +30,16 @@
3131 * @author rainman
3232 *
3333 */
34 -public class IndexId {
 34+public class IndexId
 35+{
3536 static org.apache.log4j.Logger log = Logger.getLogger(IndexId.class);
 37+
3638 /** Where the index is */
3739 protected String indexHost;
3840 /** Path to index on remote machine */
3941 protected String indexRsyncPath;
4042
41 - /** Type (single, mainsplit, split) in string repesentation */
 43+ /** Type (single, mainsplit, split) in string representation */
4244 protected String typeString;
4345 /** Parameters associated with type, e.g. number of split parts */
4446 protected Hashtable<String,String> typeParams;

Comments

#Comment by Nikerabbit (talk | contribs)   09:29, 15 January 2012

Typos you will find plenty of :).

What comes to coding style, can we stick the brace on the same line style seemingly used in both in our PHP code and in the Lucene Java code?

Status & tagging log