r108934 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108933‎ | r108934 | r108935 >
Date:18:35, 14 January 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
drop mentors field in orgs table
Modified paths:
  • /trunk/extensions/EducationProgram/includes/EPOrg.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPOrgPager.php (modified) (history)
  • /trunk/extensions/EducationProgram/includes/EPTermPager.php (modified) (history)
  • /trunk/extensions/EducationProgram/sql/EducationProgram.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/EducationProgram/sql/EducationProgram.sql
@@ -13,7 +13,6 @@
1414 org_active TINYINT unsigned NOT NULL, -- If the org has any active terms
1515 org_courses SMALLINT unsigned NOT NULL, -- Amount of courses
1616 org_terms SMALLINT unsigned NOT NULL, -- Amount of terms
17 - org_mentors SMALLINT unsigned NOT NULL, -- Amount of mentors
1817 org_students INT unsigned NOT NULL -- Amount of students
1918 ) /*$wgDBTableOptions*/;
2019
Index: trunk/extensions/EducationProgram/includes/EPOrgPager.php
@@ -34,7 +34,6 @@
3535 'country',
3636 'courses',
3737 'terms',
38 - 'mentors',
3938 'students',
4039 'active',
4140 );
@@ -72,7 +71,7 @@
7372 $countries = array_flip( efEpGetCountryOptions( $this->getLanguage()->getCode() ) );
7473 $value = htmlspecialchars( $countries[$value] );
7574 break;
76 - case 'courses': case 'mentors': case 'students': case 'terms':
 75+ case 'courses': case 'students': case 'terms':
7776 $rawValue = $value;
7877 $value = htmlspecialchars( $this->getLanguage()->formatNum( $value ) );
7978
@@ -104,7 +103,6 @@
105104 'city',
106105 'country',
107106 'courses',
108 - 'mentors',
109107 'students',
110108 'terms',
111109 'active',
Index: trunk/extensions/EducationProgram/includes/EPTermPager.php
@@ -115,7 +115,7 @@
116116 unset( $fields['org_id'] );
117117 }
118118
119 - $fields = wfArrayInsertAfter( $fields, array( '_status' => 'status' ), 'end' );
 119+ $fields = wfArrayInsertAfter( $fields, array( '_status' => 'status' ), 'students' );
120120
121121 return $fields;
122122 }
Index: trunk/extensions/EducationProgram/includes/EPOrg.php
@@ -47,7 +47,6 @@
4848 'active' => 'bool',
4949 'courses' => 'int',
5050 'terms' => 'int',
51 - 'mentors' => 'int',
5251 'students' => 'int',
5352 );
5453 }
@@ -65,7 +64,6 @@
6665 'active' => false,
6766 'courses' => 0,
6867 'terms' => 0,
69 - 'mentors' => 0,
7068 'students' => 0,
7169 );
7270 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r108935follow up to r108934 - forgot index and stuff in patch filejeroendedauw19:06, 14 January 2012
r108972Follow up to r108934; rem refs to removed fieldjeroendedauw13:06, 15 January 2012

Status & tagging log