r108912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108911‎ | r108912 | r108913 >
Date:15:59, 14 January 2012
Author:reedy
Status:ok (Comments)
Tags:miscextensions 
Comment:
Bug 33713 - Show "previous" revisions in addition to follow-ups

Add the followed-up list to CodeRevisionView
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
——@@ -14,6 +14,7 @@
1515 'code-rev-title' => '$1 - Code Review',
1616 'code-comments' => 'Comments',
1717 'code-references' => 'Follow-up revisions',
 18+ 'code-referenced' => 'Followed-up revisions',
1819 'code-change-status' => "changed the '''status''' of $1",
1920 'code-change-tags' => "changed the '''tags''' for $1",
2021 'code-change-removed' => 'removed:',
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
——@@ -186,6 +186,12 @@
187187 "</h2>\n" . $this->formatReferences( $references, $userCanAssociate );
188188 }
189189
 190+ $referenced = $this->mRev->getFollowedUpRevisions();
 191+ if ( count( $referenced ) ) {
 192+ $html .= "<h2 id='code-references'>" . wfMsgHtml( 'code-referenced' ) .
 193+ "</h2>\n" . $this->formatReferences( $referenced, false );
 194+ }
 195+
190196 # Add revision comments
191197 if ( $comments ) {
192198 $html .= "<h2 id='code-comments'>" . wfMsgHtml( 'code-comments' ) .

Follow-up revisions

RevisionCommit summaryAuthorDate
r108920Few more bits of refactoring for bug 33713reedy17:02, 14 January 2012
r108922And that should be the rest of bug 33713reedy17:13, 14 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108907Bit of prep work for bug 33713...reedy15:25, 14 January 2012
r108911Bug 33713 - Show "previous" revisions in addition to follow-ups...reedy15:54, 14 January 2012

Comments

#Comment by 😂 (talk | contribs)   15:01, 21 February 2012

"Followed-up revisions" is confusing. Perhaps "This revision follows-up:"

#Comment by Krinkle (talk | contribs)   15:04, 21 February 2012

I'd also like to try positioning this section above the diff rather than below the "Follow-up revisions". What do you think?

#Comment by Reedy (talk | contribs)   15:10, 21 February 2012

Indeed, it does become somewhat ambiguous with similar terminology. I couldn't think of anything better. Hey, at least it's only an i18n change.

Krinkle: Sure, just remember we're not going to be using CodeReview for too long into the mysterious future...

#Comment by Krinkle (talk | contribs)   15:17, 21 February 2012

True, but we'll be looking at it for a while still (in read-only) I guess.

Status & tagging log