r108905 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108904‎ | r108905 | r108906 >
Date:14:58, 14 January 2012
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_RSSlink.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/RELEASE-NOTES
@@ -9,6 +9,7 @@
1010 production until the actual release.
1111
1212 * Fixed fatal error occurring for some invalid property definitions (bug 33652).
 13+* Fixed error in RSS when using creator or date parameters (bug 33721).
1314
1415 == SMW 1.7.0.1 ==
1516
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_RSSlink.php
@@ -71,11 +71,11 @@
7272 // mechanism to add whatever you want :)
7373 $req = $field->getPrintRequest();
7474 if ( strtolower( $req->getLabel() ) == 'creator' ) {
75 - foreach ( $field->getContent() as $entry ) {
 75+ while ( $entry = $field->getNextDataValue() ) {
7676 $creators[] = $entry->getShortWikiText();
7777 }
7878 } elseif ( ( strtolower( $req->getLabel() ) == 'date' ) && ( $req->getTypeID() == '_dat' ) ) {
79 - foreach ( $field->getContent() as $entry ) {
 79+ while ( $entry = $field->getNextDataValue() ) {
8080 $dates[] = $entry->getXMLSchemaDate();
8181 }
8282 }