r108904 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108903‎ | r108904 | r108905 >
Date:14:53, 14 January 2012
Author:ialex
Status:ok
Tags:
Comment:
No need to do the safe_mode check on every request in $wgAdditionalMailParams is set; that variable will not be passed to mail() if safe_mode is enabled since r99411
Modified paths:
  • /trunk/phase3/includes/Setup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Setup.php
@@ -498,12 +498,6 @@
499499
500500 $wgDeferredUpdateList = array();
501501
502 -// We need to check for safe_mode, because mail() will throw an E_NOTICE
503 -// on additional parameters
504 -if( !is_null($wgAdditionalMailParams) && wfIniGetBool('safe_mode') ) {
505 - $wgAdditionalMailParams = null;
506 -}
507 -
508502 wfProfileOut( $fname . '-globals' );
509503 wfProfileIn( $fname . '-extensions' );
510504

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99411Unbreak sending emails using mailTargets() in safe_modemaxsem17:41, 10 October 2011

Status & tagging log