r108843 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108842‎ | r108843 | r108844 >
Date:20:31, 13 January 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/Contest (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/Contest/specials/SpecialContest.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.setup.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount.setup.php
@@ -21,7 +21,7 @@
2222 $frontendDir = "$dir/frontend";
2323 $langDir = "$dir/frontend/language/";
2424 $spActionDir = "$dir/frontend/specialpages/actions";
25 - $spReportDir = "$dir/frontend/specialpages/reports";
 25+ //$spReportDir = "$dir/frontend/specialpages/reports";
2626
2727 # Main i18n file and special page alias file
2828 $messagesFiles['ConfirmAccount'] = "$langDir/ConfirmAccount.i18n.php";
Index: branches/wmf/1.18wmf1/extensions/Contest/specials/SpecialContest.php
@@ -256,7 +256,7 @@
257257 }
258258
259259 if ( $req->getSessionData( 'contestant-challenge' ) ) {
260 - $challenge = ContestChallenge::s()->selectRow( 'id', array( 'title' => $req->getSessionData( 'contestant-' . $field ) ) );
 260+ $challenge = ContestChallenge::s()->selectRow( 'id', array( 'title' => $req->getSessionData( 'contestant-challenge' ) ) );
261261
262262 if ( $challenge !== false ) {
263263 $conds['contestant_challenge_id'] = $challenge->getField( 'id' );
Property changes on: branches/wmf/1.18wmf1/extensions/Contest
___________________________________________________________________
Modified: svn:mergeinfo
264264 Merged /trunk/extensions/Contest:r108841

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108841fix fail causing the challenge filter to not workjeroendedauw20:25, 13 January 2012

Comments

#Comment by Reedy (talk | contribs)   20:46, 13 January 2012

Well that was fail

For the ConfirmAccount commit, $spReportDir is unused

Status & tagging log