r108789 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108788‎ | r108789 | r108790 >
Date:02:53, 13 January 2012
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
adding embargoed countries back
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.db.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/CentralNotice.db.php
——@@ -422,9 +422,6 @@
423423 if ( is_callable( array( 'CountryNames', 'getNames' ) ) ) {
424424 // Retrieve the list of countries in user's language (via CLDR)
425425 $countries = CountryNames::getNames( $code );
426 - unset( $countries['CU'] ); // Cuba
427 - unset( $countries['IR'] ); // Iran
428 - unset( $countries['SY'] ); // Syria
429426 }
430427
431428 if ( !$countries ) {
——@@ -484,7 +481,7 @@
485482 'CR'=>'Costa Rica',
486483 'CI'=>'Côte d\'Ivoire',
487484 'HR'=>'Croatia',
488 - //'CU'=>'Cuba',
 485+ 'CU'=>'Cuba',
489486 'CY'=>'Cyprus',
490487 'CZ'=>'Czech Republic',
491488 'DK'=>'Denmark',
——@@ -530,7 +527,7 @@
531528 'IS'=>'Iceland',
532529 'IN'=>'India',
533530 'ID'=>'Indonesia',
534 - //'IR'=>'Iran',
 531+ 'IR'=>'Iran',
535532 'IQ'=>'Iraq',
536533 'IE'=>'Ireland',
537534 'IL'=>'Israel',
——@@ -638,7 +635,7 @@
639636 'SZ'=>'Swaziland',
640637 'SE'=>'Sweden',
641638 'CH'=>'Switzerland',
642 - //'SY'=>'Syrian Arab Republic',
 639+ 'SY'=>'Syrian Arab Republic',
643640 'TW'=>'Taiwan',
644641 'TJ'=>'Tajikistan',
645642 'TZ'=>'Tanzania',

Follow-up revisions

RevisionCommit summaryAuthorDate
r108949MFT r108789reedy02:31, 15 January 2012

Comments

#Comment by Johnduhart (talk | contribs)   02:57, 15 January 2012

In the future can we please make hooks for this?

#Comment by Reedy (talk | contribs)   02:58, 15 January 2012

For uncommenting code? :p

#Comment by Johnduhart (talk | contribs)   03:07, 15 January 2012

No for commenting it in the first place :p

Before the return 

wfRunHooks( 'CentralNoticeCountries', array( &$countries ) );

Then you hook in CommonSettings to unset, etc.

Status & tagging log