r108786 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108785‎ | r108786 | r108787 >
Date:02:30, 13 January 2012
Author:reedy
Status:resolved
Tags:
Comment:
A couple more for r108785

More doucmentations
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)
  • /trunk/phase3/includes/Preferences.php (modified) (history)
  • /trunk/phase3/includes/filerepo/file/FSFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/filerepo/file/FSFile.php
@@ -196,7 +196,7 @@
197197 * Get the final file extension from a file system path
198198 *
199199 * @param $path string
200 - * @returns string
 200+ * @return string
201201 */
202202 public static function extensionFromPath( $path ) {
203203 $i = strrpos( $path, '.' );
Index: trunk/phase3/includes/HTMLForm.php
@@ -1115,7 +1115,7 @@
11161116 /**
11171117 * flatten an array of options to a single array, for instance,
11181118 * a set of <options> inside <optgroups>.
1119 - * @param $options Associative Array with values either Strings
 1119+ * @param $options array Associative Array with values either Strings
11201120 * or Arrays
11211121 * @return Array flattened input
11221122 */
Index: trunk/phase3/includes/Preferences.php
@@ -509,10 +509,10 @@
510510
511511 /**
512512 * @param $user User
513 - * @param $context IContextSource
 513+ * @param $context ContextSource
514514 * @param $defaultPreferences Array
515515 */
516 - static function filesPreferences( $user, IContextSource $context, &$defaultPreferences ) {
 516+ static function filesPreferences( $user, ContextSource $context, &$defaultPreferences ) {
517517 ## Files #####################################
518518 $defaultPreferences['imagesize'] = array(
519519 'type' => 'select',
@@ -530,11 +530,11 @@
531531
532532 /**
533533 * @param $user User
534 - * @param $context IContextSource
 534+ * @param $context ContextSource
535535 * @param $defaultPreferences
536536 * @return void
537537 */
538 - static function datetimePreferences( $user, IContextSource $context, &$defaultPreferences ) {
 538+ static function datetimePreferences( $user, ContextSource $context, &$defaultPreferences ) {
539539 ## Date and time #####################################
540540 $dateOptions = self::getDateOptions( $context );
541541 if ( $dateOptions ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r108788Partial revert ContextSource changes from r108785, r108786reedy02:40, 13 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108785Documentation...reedy02:27, 13 January 2012

Status & tagging log