r108762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108761‎ | r108762 | r108763 >
Date:21:23, 12 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Use simpler utility functions

Followup r108760, drop other /archives
Modified paths:
  • /trunk/extensions/ConfirmAccount/backend/schema/ConfirmAccountUpdater.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/backend/schema/ConfirmAccountUpdater.hooks.php
@@ -13,12 +13,11 @@
1414 if ( $updater->getDB()->getType() == 'mysql' ) {
1515 $base = "$base/mysql";
1616
17 - $updater->addExtensionUpdate( array( 'addTable', 'account_requests', "$base/ConfirmAccount.sql", true ) );
18 - $updater->addExtensionUpdate( array( 'addField', 'account_requests', 'acr_filename',
19 - "$base/archives/patch-acr_filename.sql", true ) );
20 - $updater->addExtensionUpdate( array( 'addTable', 'account_credentials', "$base/patch-account_credentials.sql", true ) );
21 - $updater->addExtensionUpdate( array( 'addField', 'account_requests', 'acr_areas', "$base/patch-acr_areas.sql", true ) );
22 - $updater->addExtensionUpdate( array( 'addIndex', 'account_requests', 'acr_email', "$base/patch-email-index.sql", true ) );
 17+ $updater->addExtensionTable( 'account_requests', "$base/ConfirmAccount.sql", true );
 18+ $updater->addExtensionField( 'account_requests', 'acr_filename', "$base/patch-acr_filename.sql" );
 19+ $updater->addExtensionTable( 'addTable', 'account_credentials', "$base/patch-account_credentials.sql", true );
 20+ $updater->addExtensionField( 'account_requests', 'acr_areas', "$base/patch-acr_areas.sql", true );
 21+ $updater->addExtensionIndex( 'account_requests', 'acr_email', "$base/patch-email-index.sql", true );
2322 } elseif ( $updater->getDB()->getType() == 'postgres' ) {
2423 $base = "$base/postgres";
2524

Follow-up revisions

RevisionCommit summaryAuthorDate
r109252Fix for r108762: 'addTable' was left in array, breaking update.phpaaron23:59, 17 January 2012
r109905r108762: Removed unused cruft parameters to updater functionsaaron06:07, 24 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108760The patches aren't in /archivesreedy21:19, 12 January 2012

Status & tagging log