r108729 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108728‎ | r108729 | r108730 >
Date:16:53, 12 January 2012
Author:hashar
Status:ok (Comments)
Tags:
Comment:
testswarm: catch exception to avoid trace :)

This happen because we do svn log on a revision that does not exist.
Returning null is fine.
Modified paths:
  • /trunk/tools/testswarm/scripts/testswarm-mw-fetcher.php (modified) (history)

Diff [purge]

Index: trunk/tools/testswarm/scripts/testswarm-mw-fetcher.php
@@ -226,7 +226,11 @@
227227 $this->debug( 'Checkouts dir empty? Looking up remote repo...', __METHOD__ );
228228 $next = $this->minRev;
229229 } else {
230 - $next = $this->getNextFollowingRevId( $cur );
 230+ try {
 231+ $next = $this->getNextFollowingRevId( $cur );
 232+ } catch ( Exception $e ) {
 233+ $next = null;
 234+ }
231235 }
232236 return $next;
233237 }

Comments

#Comment by Hashar (talk | contribs)   16:56, 12 January 2012

Status & tagging log