r108716 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108715‎ | r108716 | r108717 >
Date:10:59, 12 January 2012
Author:hashar
Status:ok
Tags:
Comment:
(bug 32508) Fix updater output

site_stats updated is still a database action.
Purge cache is now the very last one.

Output:

<snip>
...site_stats is populated...done.
Purging caches...done.

Done.
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -250,6 +250,10 @@
251251
252252 $this->setAppliedUpdates( $wgVersion, $this->updates );
253253
 254+ if ( isset( $what['stats'] ) ) {
 255+ $this->checkStats();
 256+ }
 257+
254258 if ( isset( $what['purge'] ) ) {
255259 $this->purgeCache();
256260
@@ -257,9 +261,6 @@
258262 $this->rebuildLocalisationCache();
259263 }
260264 }
261 - if ( isset( $what['stats'] ) ) {
262 - $this->checkStats();
263 - }
264265 }
265266
266267 /**
@@ -562,7 +563,7 @@
563564 * Check the site_stats table is not properly populated.
564565 */
565566 protected function checkStats() {
566 - $this->output( "Checking site_stats row..." );
 567+ $this->output( "...site_stats is populated..." );
567568 $row = $this->db->selectRow( 'site_stats', '*', array( 'ss_row_id' => 1 ), __METHOD__ );
568569 if ( $row === false ) {
569570 $this->output( "data is missing! rebuilding...\n" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103892revert r103691 that makes update.php output garbage...hashar13:28, 22 November 2011
r103917Partial revert of r103697 for bug 32508reedy16:28, 22 November 2011
r105531(bug 32508) clean up update.php messages...hashar10:04, 8 December 2011

Status & tagging log