r105531 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r105530‎ | r105531 | r105532 >
Date:10:04, 8 December 2011
Author:hashar
Status:ok
Tags:
Comment:
(bug 32508) clean up update.php messages

The user_options migration messages were not prefixed with '...' and
were split on several lines. This patch make the output messages more
inline with the existant ones.

Follow-up r103917


. <-- that is a patch of ink sorry. ><OO>
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/convertUserOptions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/convertUserOptions.php
@@ -33,12 +33,12 @@
3434 }
3535
3636 public function execute() {
37 - $this->output( "Beginning batch conversion of user options.\n" );
 37+ $this->output( "...batch conversion of user_options: " );
3838 $id = 0;
3939 $dbw = wfGetDB( DB_MASTER );
4040
4141 if ( !$dbw->fieldExists( 'user', 'user_options', __METHOD__ ) ) {
42 - $this->output( "No user_options field in the user table. Nothing to migrate..." );
 42+ $this->output( "nothing to migrate. " );
4343 return;
4444 }
4545 while ( $id !== null ) {
@@ -57,7 +57,7 @@
5858 $this->output( "--Converted to ID $id\n" );
5959 }
6060 }
61 - $this->output( "Conversion done. Converted " . $this->mConversionCount . " user records.\n" );
 61+ $this->output( "done. Converted " . $this->mConversionCount . " user records.\n" );
6262 }
6363
6464 /**
Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -657,7 +657,6 @@
658658 */
659659 protected function doMigrateUserOptions() {
660660 $cl = $this->maintenance->runChild( 'ConvertUserOptions', 'convertUserOptions.php' );
661 - $this->output( "Migrating remaining user_options... " );
662661 $cl->execute();
663662 $this->output( "done.\n" );
664663 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r108716(bug 32508) Fix updater output...hashar10:59, 12 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103892revert r103691 that makes update.php output garbage...hashar13:28, 22 November 2011
r103917Partial revert of r103697 for bug 32508reedy16:28, 22 November 2011

Status & tagging log