r108628 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108627‎ | r108628 | r108629 >
Date:15:42, 11 January 2012
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Made Parser::addTrackingCategory() public to benefit tag hooks/parser functions developers
Modified paths:
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/Parser.php
@@ -3853,7 +3853,7 @@
38543854 * @param $msg String: message key
38553855 * @return Boolean: whether the addition was successful
38563856 */
3857 - protected function addTrackingCategory( $msg ) {
 3857+ public function addTrackingCategory( $msg ) {
38583858 if ( $this->mTitle->getNamespace() === NS_SPECIAL ) {
38593859 wfDebug( __METHOD__.": Not adding tracking category $msg to special page!\n" );
38603860 return false;

Comments

#Comment by Nikerabbit (talk | contribs)   19:22, 11 January 2012

Maybe add a note that this method is public since 1.19?

Status & tagging log