r108594 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108593‎ | r108594 | r108595 >
Date:02:14, 11 January 2012
Author:oren
Status:ok (Comments)
Tags:
Comment:
added comment on improving PHP source parsing
Modified paths:
  • /trunk/lucene-search-2/src/org/wikimedia/lsearch/util/PHPParser.java (modified) (history)

Diff [purge]

Index: trunk/lucene-search-2/src/org/wikimedia/lsearch/util/PHPParser.java
@@ -14,12 +14,16 @@
1515
1616 import org.wikimedia.lsearch.search.NamespaceFilter;
1717
 18+
1819 /**
1920 * Extract some variable from MediaWiki MessageXX.php files. In particular,
2021 * the localized namespace names (needed for proper parsing of wiki code).
2122 *
2223 * One day, make this implementation suck less, and actually parse some PHP,
2324 * instead of just catch stuff with regexps...
 25+ *
 26+ * TODO: use the PHP ANTLR grammar to improve
 27+ * it is at code.google.com/p/phpparser
2428 *
2529 * @author rainman
2630 *

Comments

#Comment by Nikerabbit (talk | contribs)   13:09, 11 January 2012

Sounds like a good idea.

Status & tagging log