r108558 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108557‎ | r108558 | r108559 >
Date:22:59, 10 January 2012
Author:yaron
Status:resolved
Tags:
Comment:
Follow-up to r108516 - after LanguageGetMagic hook was removed, a call to SF_Magic.php should have been added
Modified paths:
  • /trunk/extensions/SemanticForms/SemanticForms.php (modified) (history)
  • /trunk/extensions/SemanticForms/languages/SF_Messages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/SemanticForms.php
@@ -170,6 +170,7 @@
171171
172172 $wgExtensionMessagesFiles['SemanticForms'] = $sfgIP . '/languages/SF_Messages.php';
173173 $wgExtensionMessagesFiles['SemanticFormsAlias'] = $sfgIP . '/languages/SF_Aliases.php';
 174+$wgExtensionMessagesFiles['SemanticFormsMagic'] = $sfgIP . '/languages/SF_Magic.php';
174175 // Allow for popup windows for file upload
175176 $wgEditPageFrameOptions = 'SAMEORIGIN';
176177
Index: trunk/extensions/SemanticForms/languages/SF_Messages.php
@@ -7,9 +7,6 @@
88 * @ingroup SF
99 */
1010
11 -// FIXME: Can be enabled when new style magic words are used (introduced in r52503)
12 -// require_once( dirname( __FILE__ ) . '/SF_Magic.php' );
13 -
1411 $messages = array();
1512
1613 /** English

Follow-up revisions

RevisionCommit summaryAuthorDate
r108574Don't include files with $magicWords, but use $wgExtensionMessagesFiles....siebrand00:23, 11 January 2012
r108593Follow-up to r108558 - added 'autoedit' to set of magic wordsyaron02:09, 11 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108516Removed 'LanguageGetMagic' code - no longer needed, since MW < 1.16 support w...yaron16:26, 10 January 2012

Status & tagging log