r108532 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r108531‎ | r108532 | r108533 >
Date:18:42, 10 January 2012
Author:reedy
Status:ok
Tags:
Comment:
Fix whitespace

Fix/improve documentation
Modified paths:
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php (modified) (history)
  • /trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccessTemplate.php (modified) (history)
  • /trunk/phase3/includes/SiteStats.php (modified) (history)
  • /trunk/phase3/includes/parser/StripState.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageBs.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SiteStats.php
@@ -409,7 +409,7 @@
410410 * Do all updates and commit them. More or less a replacement
411411 * for the original initStats, but without output.
412412 *
413 - * @param $database Boolean or DatabaseBase:
 413+ * @param $database DatabaseBase|bool
414414 * - Boolean: whether to use the master DB
415415 * - DatabaseBase: database connection to use
416416 * @param $options Array of options, may contain the following values
Index: trunk/phase3/includes/parser/StripState.php
@@ -11,6 +11,9 @@
1212
1313 protected $tempType, $tempMergePrefix;
1414
 15+ /**
 16+ * @param $prefix string
 17+ */
1518 function __construct( $prefix ) {
1619 $this->prefix = $prefix;
1720 $this->data = array(
@@ -170,6 +173,10 @@
171174 return $texts;
172175 }
173176
 177+ /**
 178+ * @param $m
 179+ * @return string
 180+ */
174181 protected function mergeCallback( $m ) {
175182 $key = $m[1];
176183 return "{$this->prefix}{$this->tempMergePrefix}-$key" . Parser::MARKER_SUFFIX;
Index: trunk/phase3/languages/classes/LanguageBs.php
@@ -30,9 +30,10 @@
3131 }
3232 }
3333
34 - # Convert from the nominative form of a noun to some other case
35 - # Invoked with {{GRAMMAR:case|word}}
3634 /**
 35+ * Convert from the nominative form of a noun to some other case
 36+ * Invoked with {{GRAMMAR:case|word}}
 37+ *
3738 * Cases: genitiv, dativ, akuzativ, vokativ, instrumental, lokativ
3839 *
3940 * @param $word string
Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccess.body.php
@@ -383,8 +383,8 @@
384384 wfProfileOut( __METHOD__ );
385385 return true;
386386 }
387 -
388 - private static function createCarrierOptionsFromWikiText() {
 387+
 388+ private static function createCarrierOptionsFromWikiText() {
389389 global $wgMemc;
390390 wfProfileIn( __METHOD__ );
391391 $carrierOptionsWikiPage = wfMsg( 'zero-rated-mobile-access-carrier-options-wiki-page' );
Index: trunk/extensions/ZeroRatedMobileAccess/ZeroRatedMobileAccessTemplate.php
@@ -21,8 +21,7 @@
2222
2323 /**
2424 * Sets the value $value to $name
25 - * @param $name
26 - * @param $value
 25+ * @param $options array
2726 */
2827 public function setByArray( $options ) {
2928 foreach ($options as $name => $value ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r1085711.18wmf1: MFT r106907 - r108532preilly00:07, 11 January 2012

Status & tagging log