r108517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r108516‎ | r108517 | r108518 >
Date:16:37, 10 January 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
[apply] PHP Parse error: syntax error, unexpected T_VARIABLE, expecting T_STRING in /var/lib/jenkins/jobs/MediaWiki-lint/workspace/mw-extensions/WindowsAzureSDK/lib/PHPAzure/library/Microsoft/WindowsAzure/CommandLine/Scaffolders/ScaffoldTemplateScaffolder/resources/index.php on line 10
[apply] Errors parsing /var/lib/jenkins/jobs/MediaWiki-lint/workspace/mw-extensions/WindowsAzureSDK/lib/PHPAzure/library/Microsoft/WindowsAzure/CommandLine/Scaffolders/ScaffoldTemplateScaffolder/resources/index.php
Modified paths:
  • /trunk/extensions/WindowsAzureSDK/lib/PHPAzure/library/Microsoft/WindowsAzure/CommandLine/Scaffolders/ScaffoldTemplateScaffolder/resources/index.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WindowsAzureSDK/lib/PHPAzure/library/Microsoft/WindowsAzure/CommandLine/Scaffolders/ScaffoldTemplateScaffolder/resources/index.php
——@@ -7,7 +7,7 @@
88 * @command-handler-footer
99 * @command-handler-footer Optional $Name$Scaffolder footer information.
1010 */
11 -class $Name$Scaffolder
 11+class NameScaffolder/*$Name$Scaffolder*/
1212 extends Microsoft_WindowsAzure_CommandLine_PackageScaffolder_PackageScaffolderAbstract
1313 {
1414 /**
——@@ -38,4 +38,4 @@
3939 ));
4040 $this->log('Applied transforms.');
4141 }
42 -}
\ No newline at end of file
 42+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r108463include Windows Azure SDK for PHP into extensionmglaser19:38, 9 January 2012

Comments

#Comment by Reedy (talk | contribs)   16:46, 10 January 2012

Follows up r108463

#Comment by Blobaugh (talk | contribs)   17:08, 10 January 2012

This is an "error by design" and not really an error. This file can be removed. I will shortly review the committed Windows Azure SDK for PHP files and strip out unneeded files.

#Comment by Reedy (talk | contribs)   17:08, 10 January 2012

Cheers. It breaks our php lint tests, which is annoying

Status & tagging log